Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Revamp Report a bug page with recaptcha and private bug reporting #1240

Closed
wants to merge 23 commits into from
Closed

Feature: Revamp Report a bug page with recaptcha and private bug reporting #1240

wants to merge 23 commits into from

Conversation

AtmegaBuzz
Copy link
Collaborator

@AtmegaBuzz AtmegaBuzz commented May 7, 2023

New Report a bug page #1231

image

Preview

image

@AtmegaBuzz AtmegaBuzz marked this pull request as draft May 7, 2023 19:57
@AtmegaBuzz AtmegaBuzz marked this pull request as ready for review May 8, 2023 06:50
@AtmegaBuzz AtmegaBuzz requested a review from DonnieBLT May 8, 2023 06:52
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a recpacha, the simple captcha is working fine? Also my main issue with this new design is that it's too large for the screen - can you make everything fit on one page above the fold?

@AtmegaBuzz
Copy link
Collaborator Author

Simple captcha is bit annoying, you have to enter every time but recaptcha it just easy for users, just one tick and done if bot comes the puzzle will be asked.
Ok got it I'll fit it in one page, will move the editor to right and other things to left.

@AtmegaBuzz
Copy link
Collaborator Author

AtmegaBuzz commented May 9, 2023

@DonnieBLT @just-ary27 How about this. will tweak it little bit. do you have any suggestions
image

@DonnieBLT
Copy link
Collaborator

Can you show the full screenshot with the browser as well? It looks good but maybe it could be a bit smaller all around

@AtmegaBuzz
Copy link
Collaborator Author

AtmegaBuzz commented May 9, 2023

image
image

I will reduce the width of the components also uniform the padding.
The screenshots should be max 5

@justary27
Copy link
Collaborator

justary27 commented May 9, 2023

I'll suggest adding some padding in the bug visibility checkboxes. Also, can I see the added screenshots as a preview on the same screen? Also, can you share a mobile screenshot as well?

@AtmegaBuzz
Copy link
Collaborator Author

OK I'll add the suggestions, for preview I'll add a pop up when we click on the image box in red color it will show the preview and about mobile screem I will just flex wrap it, just to be sure that desktop screen looks good before moving

@AtmegaBuzz
Copy link
Collaborator Author

image
image
image
image
image
image

@DonnieBLT @just-ary27 I've added responsiveness, for more detail view you can see the video shared on slack.

@AtmegaBuzz AtmegaBuzz requested a review from DonnieBLT May 13, 2023 04:47
@AtmegaBuzz
Copy link
Collaborator Author

@DonnieBLT I've implemented all the changes as you suggested. can you recaptcha keys on the server env. I'll send mine or you can create it's simple

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes requested

blt/urls.py Outdated Show resolved Hide resolved
website/alternative_views.py Outdated Show resolved Hide resolved
website/models.py Show resolved Hide resolved
website/static/css/navbar.css Outdated Show resolved Hide resolved
blt/urls.py Outdated Show resolved Hide resolved
blt/urls.py Outdated Show resolved Hide resolved
blt/urls.py Outdated Show resolved Hide resolved
website/models.py Show resolved Hide resolved
blt/urls.py Outdated Show resolved Hide resolved
blt/urls.py Outdated Show resolved Hide resolved
website/models.py Show resolved Hide resolved
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit more detailed feedback

website/models.py Show resolved Hide resolved
poetry.lock Outdated Show resolved Hide resolved
blt/settings.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
website/models.py Show resolved Hide resolved
website/templates/includes/navbar.html Outdated Show resolved Hide resolved
website/templates/report.html Outdated Show resolved Hide resolved
website/tests.py Outdated Show resolved Hide resolved
website/views.py Show resolved Hide resolved
website/views.py Outdated Show resolved Hide resolved
website/models.py Show resolved Hide resolved
website/static/css/navbar.css Outdated Show resolved Hide resolved
website/templates/includes/footer.html Outdated Show resolved Hide resolved
website/templates/report.html Show resolved Hide resolved
website/views.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants