Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infinite Scroll feature #1672

Merged
merged 21 commits into from
Feb 13, 2024
Merged

infinite Scroll feature #1672

merged 21 commits into from
Feb 13, 2024

Conversation

HanilJain
Copy link
Contributor

infinite scroll is added and changes have made in filtering of bugs in newhome where & operator was used in is_hidden and other user bug but changed to | operator.

https://github.com/HanilJain/BLT/blob/44aa18ddc47ada4b3c4fc3ee9ed9383950ce1c3a/website/views.py#L198C4-L198C4

…e #1632

@errorassassin
Copy link
Contributor

This way of creating an infinite scroll homepage is ineffective as it loads all bugs on the first load of the website, even when the user is not scrolling down, making the website laggy and would keep on loading data that could be useless. We want to load the bugs as the user scrolls down, one page at a time.

@HanilJain
Copy link
Contributor Author

ohkay got it !!
so is this type of pagination required ?
https://django-endless-pagination.readthedocs.io/en/latest/twitter_pagination.html

@errorassassin
Copy link
Contributor

ohkay got it !! so is this type of pagination required ? https://django-endless-pagination.readthedocs.io/en/latest/twitter_pagination.html

yes

@HanilJain
Copy link
Contributor Author

Infinite Scroll Feature added

I changed newhome to class based view for better code and paginate with it and added a infinite scroll with the help waypoint js.
also the revert the pervious & operator logic.
This all changes will allow to load bugs as the user scrolls down.

@HanilJain HanilJain changed the title infinite Scroll feature with changes in bugs filtering infinite Scroll feature Jan 17, 2024
@HanilJain HanilJain marked this pull request as draft January 28, 2024 10:14
@HanilJain HanilJain marked this pull request as ready for review January 28, 2024 10:15
@HanilJain
Copy link
Contributor Author

@DonnieBLT could you please review the Pull request

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Can you possibly show a video?

website/views.py Outdated Show resolved Hide resolved
@HanilJain
Copy link
Contributor Author

infinite_scrolling.mp4
  • Infinite scrolling feature with twitter style pagination.
    (it loads as scroll down which can be seen in the video at network tab)
  • ensuring not listing of hidden issue.

@DonnieBLT
Copy link
Collaborator

Could we make it so that the add an issue in leaderboard are sticky?

@HanilJain
Copy link
Contributor Author

Could we make it so that the add an issue in leaderboard are sticky?

Screenshot 2024-02-09 014822

@DonnieBLT Fixed
report a bug widget was redundant as there is already button on nav. Also keeping it would have not be a good UI.

@DonnieBLT
Copy link
Collaborator

I would like to keep the quick report form

@HanilJain
Copy link
Contributor Author

I would like to keep the quick report form

@DonnieBLT Done

Screenshot 2024-02-09 114333

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be done with one script instead of 3?

@HanilJain
Copy link
Contributor Author

@DonnieBLT is it done ?

@DonnieBLT
Copy link
Collaborator

image can it be fine with one script file?

@DonnieBLT DonnieBLT enabled auto-merge (squash) February 13, 2024 05:30
@DonnieBLT DonnieBLT merged commit d8d25cc into OWASP-BLT:main Feb 13, 2024
6 checks passed
@HanilJain HanilJain deleted the issue-1632 branch February 13, 2024 08:50
@HanilJain HanilJain restored the issue-1632 branch February 13, 2024 10:01
HanilJain added a commit to HanilJain/BLT that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants