Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the broken UI at Report a Bug #1687

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Fixed the broken UI at Report a Bug #1687

merged 4 commits into from
Feb 8, 2024

Conversation

Prakhar-Shankar
Copy link
Contributor

Issue #1683

BEFORE

image

AFTER

image

  • I have put the images inside a box matching the theme of the entire website.
  • The images are horizontally scrollable, which reduces the box size and makes the website looks clean.
  • I have added a scale hovering effect on images.

@Prakhar-Shankar
Fixed the broken UI at Report a Bug
9cbfcb1 
Signed-off-by: Prakhar-Shankar <prakharshankar247@gmail.com>
DonnieBLT
DonnieBLT requested changes Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come some of the icons looks squished like the third one is there a way to fix that?

@Prakhar-Shankar
Copy link
Contributor Author

How come some of the icons looks squished like the third one is there a way to fix that?

Sure sir, I will look into it and will commit the changes

@Prakhar-Shankar
Copy link
Contributor Author

I have made the necessary changes please review it sir @DonnieBLT .
image

@DonnieBLT
Copy link
Collaborator

Can we not have a border or scroll bar please and also make the icons square (rounded corners is fine)

DonnieBLT
DonnieBLT requested changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update.

@Prakhar-Shankar
Copy link
Contributor Author

Prakhar-Shankar commented Jan 30, 2024 •
edited

Please update.

Yes sir I am working on it, should I remove the border and scroll bar ?

@Prakhar-Shankar Prakhar-Shankar mentioned this pull request Feb 5, 2024
Closed
@Prakhar-Shankar
Copy link
Contributor Author

@DonnieBLT
Sir, I have updated the UI
image

@DonnieBLT DonnieBLT enabled auto-merge (squash) February 6, 2024 20:54
@DonnieBLT DonnieBLT merged commit 8aa6624 into OWASP-BLT:main Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonnieBLT DonnieBLT DonnieBLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Prakhar-Shankar @DonnieBLT