Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task done: Embedded screenshots in markdown description(API for save images). #1725

Merged
merged 8 commits into from
Feb 4, 2024

Conversation

kr-2003
Copy link
Contributor

@kr-2003 kr-2003 commented Jan 29, 2024

Fixed #1206

Added the functionality of embedding screenshots in markdown description in the form of $[img1], $[img2], $[img3], $[img4], and $[img5].

Also added description section in issue page.(Wasn't added in the first place).

Screen.Recording.2024-01-30.at.12.40.37.AM.mov

website/templates/issue.html Fixed Show resolved Hide resolved
@kr-2003
Copy link
Contributor Author

kr-2003 commented Jan 29, 2024

@DonnieBLT Kindly review this PR.

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the security alert. Thank you for including the video.

@kr-2003
Copy link
Contributor Author

kr-2003 commented Jan 31, 2024

@DonnieBLT I added the integrity check when including a cdn. Is there any other changes need to be done?

@kr-2003
Copy link
Contributor Author

kr-2003 commented Jan 31, 2024

@DonnieBLT kindly review this pr.

@DonnieBLT DonnieBLT enabled auto-merge (squash) February 4, 2024 03:56
@DonnieBLT
Copy link
Collaborator

Nice work, thank you!

@DonnieBLT DonnieBLT merged commit 86c0f08 into OWASP-BLT:main Feb 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: API for saving images
2 participants