From 5 Base files to 2 Base Files #1800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #721
In the previous code we were having 5 base files:
which were brought down to 2 common base files in this PR :
all these html files had difference in there side navbar
if any of us have to include any of the sidebar could easily be done with
{% include ' includes/admin_sidenav.html' %}
into
sidenav we have
Note :
Also replaced
{% block hero %}
to
{% block content %}
it helps to keep similarity in all the codes.
so if you will using hero with any of the base file it wont work.
Screenshots
base.html
base_dashboard.html
sidenav.html
user_sidenav.html
company_sidenav.html
admin_sidenav.html