Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coming Soon Pages Added #1809

Merged
merged 11 commits into from
Feb 24, 2024
Merged

Coming Soon Pages Added #1809

merged 11 commits into from
Feb 24, 2024

Conversation

ATHARVA-GAWAS
Copy link
Contributor

Issue Solved
#1808

image

@ATHARVA-GAWAS ATHARVA-GAWAS mentioned this pull request Feb 21, 2024
Closed
@ATHARVA-GAWAS
Copy link
Contributor Author

Done, made a file comingsoon.html and extended it to other pages

arkid15r
arkid15r reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@arkid15r arkid15r left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the naming convention suggests "coming_soon.html".

Other than that looks good 👍 (I didn't review the page's from UI perspective)

upd: correct the extension.

@AtmegaBuzz
Copy link
Collaborator

ArcoLinux_2024-02-22_00-05-17

For UI i would suggest making it something like this

@ATHARVA-GAWAS
Copy link
Contributor Author

Better?

image

DonnieBLT
DonnieBLT requested changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make it look exactly like the suggestion?

@ATHARVA-GAWAS
Copy link
Contributor Author

Ok, i will do it

@ATHARVA-GAWAS
Copy link
Contributor Author

Is this fine?

image

DonnieBLT
DonnieBLT requested changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tweak

website/templates/coming_soon.html Outdated Show resolved Hide resolved
@ATHARVA-GAWAS
Copy link
Contributor Author

Ok

@ATHARVA-GAWAS
Copy link
Contributor Author

ATHARVA-GAWAS commented Feb 23, 2024 •
edited

Actually base.html is essential, since without it, the entire structure of the page gets messed up @DonnieBLT

@ATHARVA-GAWAS
Copy link
Contributor Author

Changes done

@DonnieBLT DonnieBLT merged commit 95d57be into OWASP-BLT:main Feb 24, 2024
7 checks passed
@ATHARVA-GAWAS ATHARVA-GAWAS mentioned this pull request Feb 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

@DonnieBLT DonnieBLT DonnieBLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ATHARVA-GAWAS @AtmegaBuzz @arkid15r @DonnieBLT