Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion of unicode password requirement V2.1.4 #691

Closed
tghosth opened this issue Nov 8, 2019 · 13 comments
Closed

Discussion of unicode password requirement V2.1.4 #691

tghosth opened this issue Nov 8, 2019 · 13 comments
Milestone

Comments

@tghosth
Copy link
Collaborator

tghosth commented Nov 8, 2019

https://twitter.com/FakeUnicode/status/1192245294429130752?s=19

@elarlang
Copy link
Collaborator

elarlang commented Nov 8, 2019

Current (v4.0.1) unicode requirement:

V2.1.4 Verify that Unicode characters are permitted in passwords. A single Unicode code point is considered a character, so 12 emoji or 64 kanji characters should be valid and permitted.

To watch entire password ruleset, use: #683 Discussion: rules for password format and content

@tghosth
Copy link
Collaborator Author

tghosth commented Nov 8, 2019

I have always struggled with unicode/emojis being a compulsory requirement here and this Twitter thread makes me think that even more so. I would consider softening this requirement somehow to focus on not blocking any characters.

@tghosth tghosth changed the title DRAFT - Discussion of unicode password requirement Discussion of unicode password requirement V2.1.4 Nov 8, 2019
@elarlang
Copy link
Collaborator

elarlang commented Nov 8, 2019

To be clear - problem is not with unicode, problem is with emojis (choosing visually pictures instead type letters).

@tghosth tghosth added this to the 4.1 milestone Dec 8, 2019
@danielcuthbert
Copy link
Collaborator

I couldn't agree more with the original thread and comments here. As someone who doesn't get emojis or uses them, it's all foreign to me but I see the appeal for wanting to use them. The arguments about warning of using them, however, should be added. In my mind, it should read something like:

Verify that no character set is blocked from being used as a source for passwords. Whilst it is important to note that the chosen input method may vary depending on situation, a single Unicode code point is considered a character, so 12 emoji or 64 kanji characters should be valid and permitted.

Thoughts?

@jmanico
Copy link
Member

jmanico commented Dec 8, 2019 via email

@danielcuthbert
Copy link
Collaborator

Verify that any printable Unicode character, including language neutral characters such as spaces and Emojis are permitted in passwords.

Short, simple and covers all. Any objections?

@elarlang
Copy link
Collaborator

Just for pointing it out - if we include "spaces", we going to merge requirements V2.1.3 and V2.1.4

V2.1.3 Verify that passwords can contain spaces and truncation is not performed. Consecutive multiple spaces MAY optionally be coalesced.
V2.1.4 Verify that Unicode characters are permitted in passwords. A single Unicode code point is considered a character, so 12 emoji or 64 kanji characters should be valid and permitted.

I actually like do-not-trim-spaces-from-password as separate requirement.

@tghosth
Copy link
Collaborator Author

tghosth commented Dec 22, 2019

So having read the original NIST, I think that these requirements should actually be as follows:

V2.1.3 Verify that password truncation is not performed. However, consecutive multiple spaces MAY optionally be coalesced.
V2.1.4 Verify that any printable Unicode character, including language neutral characters such as spaces and Emojis are permitted in passwords

Any further comments?

@jmanico
Copy link
Member

jmanico commented Dec 22, 2019 via email

@jmanico
Copy link
Member

jmanico commented Dec 22, 2019 via email

@tghosth
Copy link
Collaborator Author

tghosth commented Dec 25, 2019

V2.1.3 Verify that password truncation is not performed. However, consecutive multiple spaces may be replaced by a single space.
V2.1.4 Verify that any printable Unicode character, including language neutral characters such as spaces and Emojis are permitted in passwords

@jmanico
Copy link
Member

jmanico commented Dec 25, 2019 via email

@tghosth tghosth mentioned this issue Dec 26, 2019
@tghosth
Copy link
Collaborator Author

tghosth commented Dec 26, 2019

Opened a PR which I will merge in a week or so in case anyone has final comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants