Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a requirement about symlinks in zip files including an example reference to resolve #1424 #1670

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

tghosth
Copy link
Collaborator

@tghosth tghosth commented Jun 15, 2023

This Pull Request relates to issue #1424

@tghosth tghosth linked an issue Jun 15, 2023 that may be closed by this pull request
@tghosth tghosth changed the title Add a requirement about symlinks in zip files includling an example reference to resolve #1424 Add a requirement about symlinks in zip files including an example reference to resolve #1424 Jun 15, 2023
Copy link
Collaborator

@elarlang elarlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually want to link to pen-test reports or blog-style sources?

@tghosth
Copy link
Collaborator Author

tghosth commented Jun 15, 2023

We have done this in certain places already.

Copy link
Collaborator

@elarlang elarlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think linking to external blogs is good for the standard, but let's get the information in at the moment.

Just for note, alternative CWE candidate https://cwe.mitre.org/data/definitions/61.html

@elarlang elarlang merged commit 0995ab9 into master Jun 15, 2023
2 checks passed
@tghosth tghosth deleted the 1424-remove-symlinks-in-zip-files branch June 15, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove symlinks in zip files
2 participants