Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ghcr.io for Docker image #1680

Merged
merged 16 commits into from
Jul 27, 2023
Merged

Use ghcr.io for Docker image #1680

merged 16 commits into from
Jul 27, 2023

Conversation

ike
Copy link
Collaborator

@ike ike commented Jul 7, 2023 •
edited
Loading

The container at ghcr.io/ike/documentbuilder will need to move to the asvs repo before merging.

@ike
Copy link
Collaborator Author

ike commented Jul 7, 2023

Working action here: https://github.com/ike/ASVS/actions/runs/5490108633

This was referenced Jul 7, 2023
Closed
Closed
@tghosth tghosth marked this pull request as draft July 10, 2023 06:15
@ike ike force-pushed the github-action-image branch 4 times, most recently from fe88e86 to a2751ef Compare July 14, 2023 18:14
ike added 15 commits July 14, 2023 13:26
@ike
use CR image
19352a1
@ike
use image for gha; build image on docker changes
9eec246 
login to ghcr first
@ike
no conditional on docker target
47abc98
@ike
build and publish image
2193ecc
@ike
change something in docker dir
bbac614
@ike
reuse create-outputs
edf5d32
@ike
move reuseable
46efef8 
split debugger

wrong branch
@ike
workflow_call
f99cf70
@ike
passing secrets
e35008a 
correct branch

clean up debug action
@ike
make only 5.0
5653e30 
reorganize

run on all branches
@ike
update action versions
17d222f 
test docker change with 5.0 change
@ike
meta builder workflow
6eea31a 
move outputs to the bottom
@ike
filter dependency
7c2be51 
remove steps from output

fix if statement

fix quotes
@ike
checkout version
fb7713d 
everything changes
@ike
remove concurrency from sub workflows
e1f8671 
changes

4 changes

continue on error

use always

change 5

two changes

docker only change

everything changes
@ike ike marked this pull request as ready for review July 14, 2023 20:36
@ike
Copy link
Collaborator Author

ike commented Jul 14, 2023

Alright, @tghosth, I think this is ready to go. There's a main workflow, build-documents.yml which will check what files have changed, and then (if necessary) build and push the docker image, and after that's done it will build the appropriate versions of the document.

Basically:

does docker file need built? -> build docker image
does 4.0 need built? -> build 4.0
does 5.0 need built? -> build 5.0

@tghosth tghosth changed the base branch from master to gha-output July 27, 2023 15:04
@tghosth tghosth merged commit 6c3f288 into OWASP:gha-output Jul 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ike @tghosth