Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian translation #1973

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Italian translation #1973

wants to merge 24 commits into from

Conversation

ricsirigu
Copy link

This Pull Request relates to issue #1951

I tried to generate the document files, but the makefile is not working on my M1 Mac. I'm trying to figure out why.

@elarlang
Copy link
Collaborator

Hi @ricsirigu, thank you for this huge job! 👏

Now it's my turn to validate the structure and it may take a bit of time.

If I find some tiny formating issues, I'm going to fix them myself (as it takes less time than communicating them). Validation goes with regex matching line-by-line, so it expects line count, order and content matches for each line.

So, let's validate the syntax first and then it's time to check, is there anything needed extra for generating output formats. Those are generated by us and served as static files.

@elarlang
Copy link
Collaborator

Hi again,

so I did "few" changes :) b4f8e6a

Mostly it's spaces, tabs, line-breaks, dots etc. But there are also few things that requires action from you:

  • 0x12-V3-Session-management.md - I deleted few lines that were in English. For me those seemed translated, but just not deleted. Be sure that it was so.
  • 0x20-V12-Files-Resources.md - here, sections 12.2 and 12.4 were missing from translation. I put them back in English, please translate them

@ricsirigu
Copy link
Author

Hi @elarlang, great! :)
I confirm that the lines you deleted in 0x12-V3-Session-management.md were translated into Italian.
I have just committed the missing section related to 0x20-V12-Files-Resources.md

@elarlang
Copy link
Collaborator

Nice :)

@ricsirigu - as there were some (mentioned) surprises in the translated document, I think it makes sense to let it be read and reviewed by other Italian speakers. As I don't know any, I kindly ask you to find them :)

Meanwhile, I hope @tghosth finds time to test how it works and look for different output formats.

@tghosth
Copy link
Collaborator

tghosth commented May 30, 2024

Hi @ricsirigu, thanks for your work on this.

If the make mechanism is not working on the Mac, can you try running it in something like Google Cloud Shell:
https://cloud.google.com/shell/docs/launching-cloud-shell?cloudshell=true

https://github.com/OWASP/ASVS/blob/master/COMPILING.md

@tghosth
Copy link
Collaborator

tghosth commented Jun 13, 2024

@ricsirigu were you able to test the make functionality on google cloud shell?

@ricsirigu
Copy link
Author

@ricsirigu were you able to test the make functionality on google cloud shell?

Hi @tghosth , I'll try in the coming days 👍🏻

@ricsirigu
Copy link
Author

ricsirigu commented Jun 14, 2024

@ricsirigu were you able to test the make functionality on google cloud shell?

@tghosth I have this new issue, I'm trying to debug it

CleanShot 2024-06-14 at 14 54 20

@tghosth
Copy link
Collaborator

tghosth commented Jun 17, 2024

That is on your desktop/VM though, no? I was suggesting to use cloudshell as I described here: #1973 (comment)

@elarlang
Copy link
Collaborator

At the end, we generate static files and commit them to the repo. So it only matters, does the Makefile works for us. For others, it is just an optional development tool.

@tghosth
Copy link
Collaborator

tghosth commented Jun 18, 2024

Just saves us time if others can also do it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants