Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove X-XSS-Protection Response Header #378

Merged
merged 8 commits into from
May 4, 2020

Conversation

mackowski
Copy link
Collaborator

@mackowski mackowski commented Mar 30, 2020

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

This PR covers issue #376

@mackowski mackowski self-assigned this Mar 30, 2020
@ThunderSon
Copy link
Contributor

Yeah that works. I kept on the back burner to see if we should replace it with a small note. Didn't have proper time to think about it. What do you think?

@rbsec
Copy link
Contributor

rbsec commented Mar 30, 2020

This header is recommended in a few places, so if we're removing it here we need to remove it everywhere:

  • DotNet Security
  • NodeJS Security
  • Ruby on Rails

Given that we've going against many other people's recommendations here, I think we do still need to include it somewhere in the CS to make it clear that it's an intentional choice not to recommend it, rather than just an omission. The obvious place would be in the CSP section, something along the lines of:

Note that the X-XSS-Protection header has been deprecated by modern browsers and it's use can introduce additional security issues. As such, it is no longer recommended.

And also provide some (reputable) sources where people can go and read more information about it.

@jmanico
Copy link
Member

jmanico commented Mar 31, 2020 via email

@mackowski
Copy link
Collaborator Author

What about adding new h1 X-XSS-Protection header with content that @rbsec proposed - that way it will be easy to link to it from other places and will be easy to spot.

@jmanico
Copy link
Member

jmanico commented Mar 31, 2020 via email

@ThunderSon
Copy link
Contributor

I made an update on the 3 mentioned CSs, and on the official one for XSS. Let me know what you think

@jmanico
Copy link
Member

jmanico commented Apr 9, 2020 via email

@ThunderSon ThunderSon requested a review from rbsec May 4, 2020 09:09
@mackowski
Copy link
Collaborator Author

@ThunderSon last update looks good. @rbsec can you review it?

Copy link
Contributor

@rbsec rbsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants