Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheat sheets index from OWASP Proactive Controls point of view #52

Merged
merged 11 commits into from
Apr 2, 2019
Merged

Cheat sheets index from OWASP Proactive Controls point of view #52

merged 11 commits into from
Apr 2, 2019

Conversation

mackowski
Copy link
Collaborator

@mackowski mackowski commented Mar 27, 2019

Thank you for submitting a Pull Request to the Cheat Sheet Series.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see policy here.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to website have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g.: defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

This PR covers issue #21.

@righettod
Copy link
Member

righettod commented Mar 27, 2019 via email

@mackowski
Copy link
Collaborator Author

Yes. So far I added CS that start from letters A, B and C. During next few days I will add rest of them.

@righettod
Copy link
Member

righettod commented Mar 27, 2019 via email

@mackowski
Copy link
Collaborator Author

I finished adding all CS to proactive controls index.
Please review it!

@mackowski
Copy link
Collaborator Author

We also have to decide what to do with CSs that does not fit to top 10 OPC list.

Copy link
Member

@righettod righettod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job 🥇
I have made some little comments.
Feel free to ping me if you disagree or if you have any questions/comments.
Thanks for all 😃

IndexProactiveControls.md Outdated Show resolved Hide resolved
IndexProactiveControls.md Show resolved Hide resolved
IndexProactiveControls.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ThunderSon ThunderSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly check the comments and let's discuss them.

IndexProactiveControls.md Outdated Show resolved Hide resolved
IndexProactiveControls.md Outdated Show resolved Hide resolved
IndexProactiveControls.md Outdated Show resolved Hide resolved
IndexProactiveControls.md Outdated Show resolved Hide resolved

[Cross-Site_Request_Forgery_Prevention_Cheat_Sheet](cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.md) - Enforce Access Controls?

[Docker Security Cheat Sheet](cheatsheets/Docker_Security_Cheat_Sheet.md) - Leverage Security Frameworks and Libraries?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am neutral if this should be added or not. Docker is more of securing the infrastructure, and contains a little bit of securing secrets, not actually related to the application that the user will be accessing. @righettod What do you think about this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Docker, application is often considered as a "docker image" so it can be interesting to reference the docker CS in adequate section in order to give hint to dev team when packaging the app as "container", what do you think guys ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to actually map it to any of the mentioned proactive controls.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker is probably out of scope of this, the best place to put it is "Leverage Security Frameworks and Libraries" but docker is not a security tool.

IndexProactiveControls.md Outdated Show resolved Hide resolved
IndexProactiveControls.md Outdated Show resolved Hide resolved
IndexProactiveControls.md Outdated Show resolved Hide resolved
IndexProactiveControls.md Outdated Show resolved Hide resolved
IndexProactiveControls.md Outdated Show resolved Hide resolved
@mackowski
Copy link
Collaborator Author

@ThunderSon thanks for review. I addressed most of the yours suggestions and added a comment for rest of them.

@mackowski
Copy link
Collaborator Author

I updated this PR with adding All CSs to the index. I think that it is ready to merge.

@righettod
Copy link
Member

righettod commented Apr 2, 2019 via email

@righettod righettod merged commit 5a1044e into OWASP:master Apr 2, 2019
@righettod
Copy link
Member

@mackowski @ThunderSon PR Merged :)
I add me a issue to add the add Index to README + offline website...

mackowski referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants