Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credential stuffing #90

Merged
merged 6 commits into from
May 6, 2019
Merged

Credential stuffing #90

merged 6 commits into from
May 6, 2019

Conversation

mackowski
Copy link
Collaborator

@mackowski mackowski commented Apr 30, 2019 •
edited

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see policy here.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to website have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g.: defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue. Please end your PR text with the following line:

This PR covers issue #65.

@ThunderSon
Copy link
Contributor

I had a general read on it. It looks awesome jakub, great job!

@righettod
Copy link
Member

I will take a look ASAP...

righettod
righettod suggested changes Apr 30, 2019
View reviewed changes
Copy link
Member

@righettod righettod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just typo and one question for discution...
Very interesting update, I was not aware of this kind of attack and your update is very useful 😃

cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md Outdated Show resolved Hide resolved
@righettod righettod added this to the Roadmap 2019 milestone Apr 30, 2019
@righettod righettod mentioned this pull request Apr 30, 2019
Closed
ThunderSon
ThunderSon suggested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@ThunderSon ThunderSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple more grammar mistakes. I'll fix those in a commit directly later on. Solid update. Good job jakub.

cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md Outdated Show resolved Hide resolved
@ThunderSon ThunderSon self-requested a review May 1, 2019 19:23
@mackowski mackowski requested a review from righettod May 4, 2019 18:33
righettod
righettod approved these changes May 5, 2019
View reviewed changes
Copy link
Member

@righettod righettod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK for me.
Strong and interesting update, great job Jakub 😃

@ThunderSon
Copy link
Contributor

@mackowski I'll leave the merging to you 😄

@mackowski mackowski merged commit 113183c into OWASP:master May 6, 2019
@mackowski mackowski deleted the credential-stuffing branch May 6, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@righettod righettod righettod approved these changes

@ThunderSon ThunderSon ThunderSon approved these changes

Assignees

@mackowski mackowski

Labels
None yet
Projects
None yet
Milestone
Roadmap 2019
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mackowski @ThunderSon @righettod