Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing develop branch #1

Closed
gilliek opened this issue Apr 12, 2017 · 9 comments
Closed

Missing develop branch #1

gilliek opened this issue Apr 12, 2017 · 9 comments

Comments

@gilliek
Copy link
Contributor

gilliek commented Apr 12, 2017

Hi,

I'd like to submit a pull request but, according to your "How to contribute" guide, I should submit it to the develop branch:

Once you're ready to merge your work with others, you should go to main repository and open a Pull Request to the develop branch.

However, there is no such a branch in your repository. Could you create it or can I submit the pull request to the master branch?

Thanks,

Kevin

@ErezYalon
Copy link
Member

Hi Kevin,

For now, submit to the master branch.

Thanks,
Erez

@gilliek
Copy link
Contributor Author

gilliek commented Apr 12, 2017

Ok, thanks.

Kevin

@ErezYalon ErezYalon assigned PauloASilva and unassigned ErezYalon Apr 12, 2017
@PauloASilva
Copy link
Collaborator

Hi @gilliek,
We did update the repo with all stuff and structure required for easier maintainability and development.
Right now everything should work as documented on "How To Contribute" section and from now on Pull Requests should be opened to the develop branch.

Please let me know if you need help to sync your fork.

Regards,
Paulo

@gilliek
Copy link
Contributor Author

gilliek commented Apr 13, 2017

Hi @PauloASilva,

Thank you. Do you want me to merge my actual pull requests with the develop branch instead of master?

Best,
Kevin

@PauloASilva
Copy link
Collaborator

Hi @gilliek,
This would be awesome from you

Can you first sync your fork with this repo and then merge updated develop into your feature branch?
I think this way we will avoid conflicts.

Best,
Paulo

@PauloASilva PauloASilva reopened this Apr 13, 2017
@gilliek
Copy link
Contributor Author

gilliek commented Apr 13, 2017

Sure, I can do that.

Best,
Kevin

@gilliek
Copy link
Contributor Author

gilliek commented Apr 13, 2017

I merged my feature branches et updated the pull request. It should be ok now.

Best,
Kevin

@PauloASilva
Copy link
Collaborator

Hi @gilliek
Just to let you know that on v1.0.2 we had to rename the docs folder to src due to github-linguist misbehaviour: docs was being ignored, leading to wrong repository categorization.

I had to do it before reviewing your Pull Requests, so they are broken again: sorry about that.
If you're available to merge and update them, fantastic, otherwise I will do it myself locally but I am afraid it will take longer.

Thanks again for your contributions.

Regards,
Paulo

@gilliek
Copy link
Contributor Author

gilliek commented Apr 14, 2017

Hi @PauloASilva,

I merged and updated my PR.

Best,
Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants