Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nettacker.py executable #525

Closed
wants to merge 3 commits into from
Closed

Conversation

tristanlatr
Copy link
Contributor

Checklist

  • I have followed the Contributor Guidelines.
  • The code has been thoroughly tested in my local development environment with flake8 and pylint.
  • The code is Python 3 compatible.
  • The code follows the PEP8 styling guidelines with 4 spaces indentation.
  • This Pull Request relates to only one issue or only one feature
  • I have referenced the corresponding issue number in my commit message
  • I have added the relevant documentation.
  • My branch is up-to-date with the Upstream master branch.

Changes proposed in this pull request

Make the entry point executable

Copy link
Collaborator

@Ali-Razmjoo Ali-Razmjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't see any changes, is it ready for review?

@tristanlatr
Copy link
Contributor Author

The changes is that I’ve made the nettacker.py file executable. So there is no diff, indeed.

@Ali-Razmjoo
Copy link
Collaborator

I think we can think of alternative ways in the next version and keep it in scripting mode. perhaps adding the nettacker in OS executables' paths.

@Ali-Razmjoo Ali-Razmjoo closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants