Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Mysql brute force module protocol #559

Closed
wants to merge 14 commits into from
Closed

✨Mysql brute force module protocol #559

wants to merge 14 commits into from

Conversation

Mrinank-Bhowmick
Copy link
Contributor

@Mrinank-Bhowmick Mrinank-Bhowmick commented Apr 15, 2022 •
edited

Motivation and Context

Added Mysql brute force module in Nettacker 🎉

Changes proposed in this pull request

  • Added Mysql brute module protocol , taken reference from ftp_brute .
  • Changed Dockerfile to add a line to install mysql-connector-python library.
    • here it is placed separately as it will show error if placed in requirements.txt

Reviewers

@Ali-Razmjoo
@securestep9

Checklist

  • I have followed the Contributor Guidelines.
  • The code has been thoroughly tested in my local development environment with flake8 and pylint.
  • The code is Python 3 compatible.
  • The code follows the PEP8 styling guidelines with 4 spaces indentation.
  • This Pull Request relates to only one issue or only one feature
  • I have referenced the corresponding issue number in my commit message
  • I have added the relevant documentation.
  • My branch is up-to-date with the Upstream master branch.

Your development environment

  • OS: Docker: Debian GNU/Linux 11 (bullseye)
  • OS Version: 11
  • Python Version: 3.9

Ali-Razmjoo
Ali-Razmjoo requested changes Sep 25, 2022
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
core/module_protocols/Mysql.py Outdated Show resolved Hide resolved
modules/brute/Mysql.yaml Outdated Show resolved Hide resolved
modules/brute/Mysql.yaml Outdated Show resolved Hide resolved
core/module_protocols/Mysql.py Outdated Show resolved Hide resolved
@Mrinank-Bhowmick
Copy link
Contributor Author

@Ali-Razmjoo is it ok now?

@Mrinank-Bhowmick
Copy link
Contributor Author

@securestep9 can you please check why security/snyk test is failing

Ali-Razmjoo
Ali-Razmjoo reviewed Nov 6, 2022
View reviewed changes
core/module_protocols/core_mysql.py

class NettackMYSQLLib:
def mysql_brute_force(host, ports, usernames, passwords, timeout):
connection = sqltor.connect(host=host,user=usernames,passwd=passwords)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please apply the port here.

@Mrinank-Bhowmick Mrinank-Bhowmick mentioned this pull request Nov 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ali-Razmjoo Ali-Razmjoo Ali-Razmjoo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mrinank-Bhowmick @Ali-Razmjoo