Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makefile] add explicit call to interpreters on install target #111

Closed
wants to merge 1 commit into from
Closed

[makefile] add explicit call to interpreters on install target #111

wants to merge 1 commit into from

Conversation

samueloph
Copy link

I noticed that the build was failing on my machine because the interpreter call was missing on Makefile.

I'm not sure why this was a problem just for me, I'm building it in a clean environment using sbuild and with the following command:
make -j8 install DESTDIR=/<<PKGBUILDDIR>>/debian/o-saft AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true"

Thanks

@EnDe
Copy link
Member

EnDe commented Oct 14, 2018

The Makefile uses direct calls to scripts at various targets/rules. The shell calling these scripts should start the interpreter specified in the hashbang line. It's the responsbility of the calling system.
Adding sh/perl at one place (the install target here) would break the general behaviour.

Even I prefer scripts without useless filename extensions (like .sh or .pl), they are used for most scripts to make them work in stupid "so-called" operating systems ;-) May be the calling system needs to be prepared.

If there is a problem in some situations, I'd like to fix them, but it must be done in a general way.

Could it be that the scripts in this target are not found via $PATH?
Please post a more detailed (error) message.

Thanks.

@EnDe
Copy link
Member

EnDe commented Oct 14, 2018

install target now uses a full path for o-saft.pl
Does this solve at least half of the problem?

@samueloph
Copy link
Author

Thanks for the help, unfortunately I somehow missed your reply and just noticed it now, due to the new release.

I'm no longer calling the install target from the Makefile, but I believe I've done it earlier and it wasn't an issue. In any case, I seemed to be the only one having this issue, so I'm gonna close this PR.

@samueloph samueloph closed this Mar 10, 2022
@samueloph samueloph deleted the samueloph_makefile branch March 10, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants