Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese Translation for TOP 10 2017 #463

Closed
PauloASilva opened this issue Feb 13, 2019 · 11 comments
Closed

Portuguese Translation for TOP 10 2017 #463

PauloASilva opened this issue Feb 13, 2019 · 11 comments

Comments

@PauloASilva
Copy link
Contributor

Hi guys,
The Portuguese (pt-pt) translation is complete and I would like to open the Pull Request but I am not sure to what branch it should be done (master or golden-master)?

The README.TRANSLATIONS is not clear about that

When you're ready for us to consume your translation, please create a pull request, and we'll merge your changes.

Can you please provide some guidance?

Cheers,
Paulo A. Silva

@Neil-Smithline
Copy link
Collaborator

master

@PauloASilva
Copy link
Contributor Author

PauloASilva commented Feb 18, 2019

Hey @Neil-Smithline,
Thanks for your help.

Please review PR #464.

Cheers,
Paulo A. Silva

@Mockingbot94
Copy link

good job

@sslHello
Copy link
Collaborator

Congratulations for the Portuguese Version of the OWASP Top 10!
Thank you for your great volunteerism!
Merged with commit 59cc94a.

Cheers
Torsten

@sslHello
Copy link
Collaborator

Do you like to add it yourself at the Project Page?
Please let me know if I should do it for you and who should be attributed.
Cheers Torsten

@sslHello sslHello reopened this Feb 25, 2019
@PauloASilva
Copy link
Contributor Author

Hi @sslHello,
Thanks for your help merging the Portuguese version.

I will add it myself to the Project Page in a few minutes.

Cheers,
Paulo A. Silva

@PauloASilva
Copy link
Contributor Author

Hi @sslHello,
I had no timely response to my account request.
Because of that I would like to ask you to add the Portuguese translation to the Project Page.

You should first accept the PR #465 as it moves the PDF and ODP files to the Top 10 2017 root directory (/2017). Then, please add the following line right after the Korean one

* Portuguese <u>[https://github.com/OWASP/Top10/tree/master/2017/OWASP%20Top%2010-2017-pt_pt.pdf OWASP Top 10 2017 - Portuguese (PDF)]</u>&nbsp;<u>[https://github.com/OWASP/Top10/tree/master/2017/OWASP%20Top%2010-2017-pt_pt.odp (ODP)]</u><br/> translated by Anabela Nogueira, Carlos Serrão, Guillaume Lopes, João Pinto, João Samouco, Kembolle A. Oliveira, Paulo A. Silva, Ricardo Mourato, Rui Silva, Sérgio Domingues, Tiago Reis, Vítor Magano.

Cheers,
Paulo A. Silva

@sslHello
Copy link
Collaborator

Moved with committ e529e4e

@PauloASilva
Copy link
Contributor Author

Great!
Please find below the line to add to the Project Page: I've had no answer to my account request.

* Portuguese <u>[https://github.com/OWASP/Top10/tree/master/2017/OWASP%20Top%2010-2017-pt_pt.pdf OWASP Top 10 2017 - Portuguese (PDF)]</u>&nbsp;<u>[https://github.com/OWASP/Top10/tree/master/2017/OWASP%20Top%2010-2017-pt_pt.odp (ODP)]</u><br/> translated by Anabela Nogueira, Carlos Serrão, Guillaume Lopes, João Pinto, João Samouco, Kembolle A. Oliveira, Paulo A. Silva, Ricardo Mourato, Rui Silva, Sérgio Domingues, Tiago Reis, Vítor Magano.

Cheers,
Paulo A. Silva

@sslHello
Copy link
Collaborator

Hi Paulo,
thank you. Your Portugese version is now onlile via the OWASP web site: OWASP_Top_Ten_Project.
I've copied the pdf directly to the Wiki. The ODP is too big, it links diretly to the RAW github path of the file.
I am sorry about the delay of your account request. I'm sorry, I'm only a volunteer myself and not involved to this.

Cheers,
Torsten

@PauloASilva
Copy link
Contributor Author

Hi @sslHello,
This is awesome!

Thanks for you help.

Cheers,
Paulo A. Silva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants