Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use html.standard rules for when a semicolon is optional after &name #201

Merged
merged 2 commits into from Jun 13, 2020
Merged

Use html.standard rules for when a semicolon is optional after &name #201

merged 2 commits into from Jun 13, 2020

Conversation

mikesamuel
Copy link
Contributor

Fixed #193: &order in link broken

@mikesamuel mikesamuel mentioned this pull request Jun 2, 2020
Closed
yangbongsoo
yangbongsoo reviewed Jun 3, 2020
View reviewed changes
Copy link
Contributor

@yangbongsoo yangbongsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked some questions because the behavior of the htmlEntities decode is complicated.

And I asked you about your thoughts on contribute for sanitizer by email, so please give me your opinion. thank you.

src/main/java/org/owasp/html/HtmlEntities.java Show resolved Hide resolved
src/main/java/org/owasp/html/HtmlEntities.java Show resolved Hide resolved
@mikesamuel
Copy link
Contributor Author

Sorry for the delay in responding to your question. It dropped off my GH notifications somehow.

@mikesamuel mikesamuel merged commit 0eb359c into master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangbongsoo yangbongsoo yangbongsoo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

decoded html entities in href
2 participants
@mikesamuel @yangbongsoo