Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge 'Add RE tools to Testing Tools' into doc-ja/08-tools #1192

Merged
merged 3 commits into from May 16, 2019

Conversation

coky-t
Copy link
Contributor

@coky-t coky-t commented May 6, 2019

Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)

@commjoen commjoen requested a review from okdt May 7, 2019 05:09
Copy link
Collaborator

@okdt okdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「スクリプト対応」となっているところですが、Ghidraをちょっと見る限りですが、これは操作面の機能のことのようです。スクリプト対応と書いてしまうと、解析対象として何らかのスクリプトを扱えるように誤読されないでしょうか。難しいところですが、ここは、たとえば「グラフ作成や、(操作の)スクリプティングに対応しています」などとするのはどうでしょうか。ご検討ください。

@coky-t
Copy link
Contributor Author

coky-t commented May 10, 2019

レビューいただきありがとうございます。
「スクリプト対応」は「スクリプティング」に修正いたしました。
なお、「グラフ表示」は原文 graphing が Graph view を意識したものと考え、「グラフ作成」ではなく「グラフ表示」のままとしています。
お手数ですが、再度ご確認いただけますでしょうか。
よろしくお願いいたします。

@commjoen commjoen removed their assignment May 11, 2019
Copy link
Collaborator

@okdt okdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Thanks!!

@commjoen commjoen requested review from okdt and commjoen May 16, 2019 06:18
@commjoen
Copy link
Collaborator

Sorry, my mistake... Thank you @coky-t for your contribution & thank you @okdt for your review !

@commjoen commjoen merged commit a7e80ef into OWASP:master May 16, 2019
@coky-t coky-t deleted the doc-ja-08-tools branch May 16, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants