Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSTG-NETWORK-1 Added clearText Traffic Info #2037

Merged
merged 17 commits into from
Jan 25, 2022
Merged

MSTG-NETWORK-1 Added clearText Traffic Info #2037

merged 17 commits into from
Jan 25, 2022

Conversation

TheDauntless
Copy link
Collaborator

@TheDauntless TheDauntless commented Jan 22, 2022

Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #2008

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheDauntless, one first comment before reviewing the content itself. Could you please put all code-like elements in backticks? e.g. android:... or <application>.

Why XML elements have a \ preceding them?

See https://github.com/OWASP/owasp-mstg/blob/master/style_guide.md#in-text-keywords

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheDauntless, here are a couple of comments and suggestions. Please take a look :)

Document/0x04f-Testing-Network-Communication.md Outdated Show resolved Hide resolved
Document/0x04f-Testing-Network-Communication.md Outdated Show resolved Hide resolved
Document/0x04f-Testing-Network-Communication.md Outdated Show resolved Hide resolved
Document/0x04f-Testing-Network-Communication.md Outdated Show resolved Hide resolved
Document/0x04f-Testing-Network-Communication.md Outdated Show resolved Hide resolved
Document/0x04f-Testing-Network-Communication.md Outdated Show resolved Hide resolved
Document/0x04f-Testing-Network-Communication.md Outdated Show resolved Hide resolved
TheDauntless and others added 7 commits January 24, 2022 13:19
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
@TheDauntless
Copy link
Collaborator Author

All comments have been processed. I would prefer to link to a dedicated section on cross-platform frameworks, but since we don't have that one, I'm fine with giving an example for now.

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing :)

Document/0x04f-Testing-Network-Communication.md Outdated Show resolved Hide resolved
Document/0x04f-Testing-Network-Communication.md Outdated Show resolved Hide resolved
TheDauntless and others added 3 commits January 24, 2022 15:27
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheDauntless 🎉

@cpholguera cpholguera merged commit e3d4ba5 into master Jan 25, 2022
@cpholguera cpholguera deleted the ClearText branch January 25, 2022 07:52
@cpholguera cpholguera changed the title clearText traffic info added MSTG-NETWORK-1 - clearText traffic info added Mar 26, 2022
@cpholguera cpholguera changed the title MSTG-NETWORK-1 - clearText traffic info added MSTG-NETWORK-1 Added clearText Traffic Info Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test Case] usesCleartextTraffic in AndroidManifest
2 participants