Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change markdown images to html images #2126

Merged
merged 9 commits into from Jun 27, 2022
Merged

Change markdown images to html images #2126

merged 9 commits into from Jun 27, 2022

Conversation

TheDauntless
Copy link
Collaborator

This PR changes the following:

  • Modify markdown images to HTML images as per Remove unnecessary backslash #1979
  • Slightly modify the build process so that it works on files in the build folder rather than the original files
  • Make the sed replace pattern for images tolerant for whitespace

@TheDauntless TheDauntless mentioned this pull request Jun 27, 2022
Closed
cpholguera
cpholguera requested changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @TheDauntless. Please take a look at the comment. I'm not sure if the commented changes were really intended.

Document/0x06c-Reverse-Engineering-and-Tampering.md Outdated Show resolved Hide resolved
Document/0x06c-Reverse-Engineering-and-Tampering.md Outdated Show resolved Hide resolved
cpholguera
cpholguera requested changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what I could still catch :D

Document/0x01-Foreword.md Outdated Show resolved Hide resolved
Document/0x02-Frontispiece.md Outdated Show resolved Hide resolved
Document/0x08-Testing-Tools.md Outdated Show resolved Hide resolved
TheDauntless and others added 4 commits June 27, 2022 15:58
@TheDauntless @cpholguera
Update Document/0x08-Testing-Tools.md
e0daa62 
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
@TheDauntless @cpholguera
Update Document/0x02-Frontispiece.md
bb2999d 
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
@TheDauntless @cpholguera
Update Document/0x01-Foreword.md
ed0d5c7 
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
@TheDauntless
Merge branch 'master' of github.com:OWASP/owasp-mstg into fix-markdow…
f8a1cc1 
…n-images
cpholguera
cpholguera approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot @TheDauntless!

@cpholguera cpholguera merged commit 370c6df into master Jun 27, 2022
@cpholguera cpholguera deleted the fix-markdown-images branch June 27, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpholguera cpholguera cpholguera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheDauntless @cpholguera