Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Chapter for Reference Apps #2142 #2156

Merged
merged 5 commits into from Jul 19, 2022

Conversation

wwwhackcom
Copy link
Contributor

Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #2142.

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @wwwhackcom, please take a look at the comments. Would you mind incorporating that? Thank you!

Document/0x08b-Reference-Apps.md Outdated Show resolved Hide resolved
Document/0x08b-Reference-Apps.md Outdated Show resolved Hide resolved
Document/0x08b-Reference-Apps.md Show resolved Hide resolved
Document/0x08b-Reference-Apps.md Show resolved Hide resolved
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wwwhackcom, thanks a lot for doing the fixes. Could you please git pull origin master and fix any conflicts that might appear? That'd be very helpful and maybe we can already merge. Thank you so much!

@cpholguera cpholguera removed the tests label Jul 19, 2022
README.md Show resolved Hide resolved
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wwwhackcom this is great, thank you so much for taking the time. It's very helpful for one of the next steps that we're taking in the project which is deriving statistics and dynamic info from the MSTG 🎉

@cpholguera cpholguera merged commit 20e645f into OWASP:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Chapter for Reference Apps
2 participants