Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofreading fixes part 3 0x05c #2327

Merged
merged 3 commits into from Nov 29, 2022
Merged

Proofreading fixes part 3 0x05c #2327

merged 3 commits into from Nov 29, 2022

Conversation

Laancelot
Copy link
Contributor

Typos, links

Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #< insert number here >.

@Laancelot
Copy link
Contributor Author

Line 922 mentions the Device Monitor. It is deprecated:
https://developer.android.com/studio/profile/monitor

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small fix and we're ready to go. Thank you!

Document/0x05c-Reverse-Engineering-and-Tampering.md Outdated Show resolved Hide resolved
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
@Laancelot
Copy link
Contributor Author

@cpholguera did you see my comment on line 922 above ☝🏻 thank you 🙏🏻

@cpholguera
Copy link
Collaborator

Thank you @Laancelot! That's indeed deprecated and we should fix it. I'll open a ticket and we can merge this PR. If you would like to rewrite that section you're very welcome to take that ticket.

#2329

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Laancelot!

@cpholguera cpholguera merged commit 0b6e405 into OWASP:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants