Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Phase 1] Refactor 0x0**-Testing-Code-Quality.md #2381

Merged
merged 2 commits into from Feb 17, 2023
Merged

[Phase 1] Refactor 0x0**-Testing-Code-Quality.md #2381

merged 2 commits into from Feb 17, 2023

Conversation

cpholguera
Copy link
Collaborator

This PR closes #2212, #2218 and #2225

sushi2k
sushi2k approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@sushi2k sushi2k left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Maybe one small change, see below

Document/0x04h-Testing-Code-Quality.md Outdated Show resolved Hide resolved
@cpholguera @sushi2k
Apply suggestions from code review
4702e22 
Co-authored-by: Sven <sven@bsddaemon.org>
@cpholguera cpholguera merged commit c66a686 into master Feb 17, 2023
@cpholguera cpholguera deleted the refactor-code-build branch February 17, 2023 08:52
@cpholguera cpholguera changed the title [Phase 1] Refactor Testing-Code-Quality.md [Phase 1] Refactor 0x0**-Testing-Code-Quality.md May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushi2k sushi2k sushi2k approved these changes

@TheDauntless TheDauntless Awaiting requested review from TheDauntless

Assignees
No one assigned
Labels
Android iOS MASVS-CODE tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Phase 1] Refactor 0x04h-Testing-Code-Quality.md
2 participants
@cpholguera @sushi2k