Changed value of status_cells in yaml_to_excel.py #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2415 except for the MASVS-AUTH MASVS-CODE tab. Separate rule should be made to fix 'status dropdown bar issue' in the remaining tabs.
|
Thanks a lot for opening the PR, @bl13pbl03p! I'll take a look this week. |
cpholguera
reviewed
May 22, 2023
cpholguera
approved these changes
May 22, 2023
There was a problem hiding this comment.
@bl13pbl03p thank you so much for your help. It should be fixed now!
cpholguera
reviewed
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old value of status value contained
H8which causes the issue described in #2415. See screenshot below:Remediation:
I changed the value of status_cells from
'H8:L400'to'I13:L400'.Effectiveness:
I am not entirely sure the if the commit will help, was not able to generate a .xlsx checklist locally.
References:
The only reference that I have used was an earlier commit 3bfc72e, looking at the value of status_cells.
Possible next steps:
A separate rule should be made to fix 'status dropdown bar issue' in the remaining tabs (MASVS-AUTH MASVS-CODE), because status dropdown function is not applicable there on I13.
This PR closes #2415 except maybe for the MASVS-AUTH and MASVS-CODE tab.