[MASTG-TOOL-0015] Update drozer content and remove outdated references #2614
Conversation
There was a problem hiding this comment.
Thank you for the pull request @cyberMilosz! This is a nice update for drozer. Please find a few comments and suggestions below. Let me know if any questions.
|
|
||
| Before you can start using drozer, you'll also need the drozer agent that runs on the Android device itself. Download the latest drozer agent [from the GitHub releases page](https://github.com/FSecureLABS/drozer/releases/ "drozer GitHub releases") and install it with `adb install drozer.apk`. | ||
| ## Installing drozer |
There was a problem hiding this comment.
As part of the refactoring for the MASTG we would like to link to the tools documentation as much as possible to avoid redundancies. This is to avoid that if there are changes in the installation process that we have outdated information in the MASTG. Then it only need to be changed in the documentation of the tool. Can you therefore please remove the content of "## Installing drozer" till "### Example usage" and replace it with a short sentence and link where the installation information can be found? It seems it's mainly the readme.md in the drozer repo that has all this information available about the installation. So you might want to link to this file or another URL that you think is more appropriate.
The "### Example usage" should remain as it shows some basic usages.
tools/android/MASTG-TOOL-0015.md
Outdated
| - [Official drozer User Manual](https://labs.withsecure.com/tools/drozer "drozer User Manual") | ||
| - [drozer GitHub page](https://github.com/WithSecureLabs/drozer "GitHub repo - drozer") | ||
| - [drozer Agent GitHub page](https://github.com/WithSecureLabs/drozer "GitHub repo - drozer-agent") |
There was a problem hiding this comment.
This is the same URL as the link before. I would suggest to remove it.
There was a problem hiding this comment.
Whoops, that second link is supposed to be https://github.com/WithSecureLabs/drozer-agent - will correct soon!
|
|
||
| You can learn more about how intents are created by running `help intents` | ||
|
|
||
| #### Further information |
There was a problem hiding this comment.
This link is already used in "### Example usage". Can you remove this short section and merge it with "### Example usage"?
|
Thank you - will review ASAP and get back to you! |
|
@cyberMilosz You can just use the "Commit Suggestion" button if you agree to the proposed changes. Thanks! |
cpholguera
changed the title
Co-authored-by: Jeroen Beckers <me.githbub@dauntless.be> Co-authored-by: Sven <sven@bsddaemon.org>
This is the first PR triggered by #2598. It focuses on rewriting the tool page itself, making sure it's accurate and removing outdated references.
Further work will need to be done to restore drozer instructions that were removed from the main MASTG body. As a result, #2598 should stay open for now.