[TOOL] Adding hermes-dec as a general tool for React Native static analysis #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding writeup for hermes-dec tool, closes issue OWASP#2794 I just picked 42 as the tool number because I wasn't sure how the number scheme works, feel free to change.
|
Thanks for the contribution! I don't have any remarks on the current content, but maybe we should add a quick test to see if we are actually working with hermes BC vs normal JS? Maybe running |
cpholguera
requested changes
Jul 13, 2024
tools/generic/MASTG-TOOL-0042.md
Outdated
| @@ -0,0 +1,13 @@ | |||
| --- | |||
There was a problem hiding this comment.
Please use: MASTG-TOOL-0104
Since today you can go to the tools overview and sort by ID to find out which one would be the next to use:
https://mas.owasp.org/MASTG/tools/
Thanks!
There was a problem hiding this comment.
Thanks, will do
incorporating feedback from reviewers, thanks for the input!
cpholguera
reviewed
Jul 14, 2024
cpholguera
requested changes
Jul 14, 2024
thanks for the review, should be all set now Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Jeroen Beckers <me.githbub@dauntless.be>
|
Changes were applied @TheDauntless |
cpholguera
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding for hermes-dec to tools.
This PR closes #2794