Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cypress tests for #1306 to check for error codes #1309

Merged
merged 15 commits into from Apr 15, 2024

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Apr 2, 2024

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else: embeds error codes in docker container spoil exercisses and checks in cypress if these are present in spoils

Description

Relations

Relates to #1306

References

Checklist:

TODOs:

  • For all spoils, have standardized error responses in the spoil (config, decrypt, execute error)
  • Fix the cypress tests: error codes should not be in the spoils
  • Extend the docker container tests for each docker based challenge
  • Create a workflow in github based on docker tests for heroku.
  • Extend minikube vault test workflow with checks on each of these of the k8s/vault challenges.

GENERAL CHECKLIST:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen mentioned this pull request Apr 15, 2024
4 tasks
@commjoen commjoen changed the title First fixes for #1306 Update the cypress tests for #1306 Apr 15, 2024
@commjoen commjoen marked this pull request as ready for review April 15, 2024 21:20
@commjoen commjoen merged commit 71780f7 into master Apr 15, 2024
15 checks passed
@commjoen commjoen deleted the feature-1306-testing-update branch April 15, 2024 21:26
@commjoen commjoen changed the title Update the cypress tests for #1306 Update the cypress tests for #1306 to check for error codes Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant