Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add commitlint #628

Merged
merged 5 commits into from
Feb 25, 2023
Merged

feat: add commitlint #628

merged 5 commits into from
Feb 25, 2023

Conversation

bendehaan
Copy link
Collaborator

@bendehaan bendehaan commented Feb 21, 2023 •
edited

Closes #625

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests

commjoen
commjoen requested changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be so kind to update the readme.md and contributing.md on the process of installing precommit first please?

commjoen
commjoen reviewed Feb 22, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
commjoen
commjoen reviewed Feb 22, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
commjoen
commjoen approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM now!

@commjoen commjoen merged commit 0fba22a into master Feb 25, 2023
@commjoen commjoen deleted the feat/add-commitlint branch February 25, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen commjoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install commitlint through pre-commit hook
2 participants
@bendehaan @commjoen