Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beginner Guide Submission #653

Merged
merged 10 commits into from
Mar 2, 2023
Merged

Beginner Guide Submission #653

merged 10 commits into from
Mar 2, 2023

Conversation

puneeth072003
Copy link
Contributor

@puneeth072003 puneeth072003 commented Feb 28, 2023 •
edited

Submission of pictorial Beginner Guide including "How to add Challenges" part as requested and mentioned in the issue #558 and continuation to the PR #589

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests

bendehaan
bendehaan requested changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@bendehaan bendehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @puneeth072003! A few minor nits and we're good to go. You can just commit these in a batch in the GitHub UI, you don't have to open a new PR.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@puneeth072003 puneeth072003 mentioned this pull request Mar 2, 2023
Merged
puneeth072003 and others added 2 commits March 2, 2023 06:47
@puneeth072003 @commjoen
@dependabot @bendehaan
Adding all the requested changes (#3)
7da081b 
* feat(OWASP#631):first podman test

* Create SECURITY.md

* feat(OWASP#631): Added forgotten podman steps

feat(OWASP#631): fix podman - move to ubuntu

Update podman-test.yml

Update podman-test.yml

Update podman-test.yml

Update podman-test.yml

* feat(OWASP#631): adding colima and podman

* feat(OWASP#630): fix podman to search at docker.io

* feat(OWASP#630/OWASP#631): colima and podman tests

* feat(OWASP#630/OWASP#631): colima and podman tests (now with sleep)

* build(deps): bump checkstyle from 10.7.0 to 10.8.0

Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.7.0 to 10.8.0.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-10.7.0...checkstyle-10.8.0)

---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump cyclonedx-core-java from 7.3.1 to 7.3.2

Bumps [cyclonedx-core-java](https://github.com/CycloneDX/cyclonedx-core-java) from 7.3.1 to 7.3.2.
- [Release notes](https://github.com/CycloneDX/cyclonedx-core-java/releases)
- [Changelog](https://github.com/CycloneDX/cyclonedx-core-java/blob/master/CHANGELOG.md)
- [Commits](CycloneDX/cyclonedx-core-java@cyclonedx-core-java-7.3.1...cyclonedx-core-java-7.3.2)

---
updated-dependencies:
- dependency-name: org.cyclonedx:cyclonedx-core-java
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update .github/workflows/container-alts-test.yml

Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>

* Update .github/workflows/container-alts-test.yml

Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>

* build(deps): bump aws.sdk.version from 2.20.12 to 2.20.14

Bumps `aws.sdk.version` from 2.20.12 to 2.20.14.

Updates `sts` from 2.20.12 to 2.20.14

Updates `ssm` from 2.20.12 to 2.20.14

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:sts
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: software.amazon.awssdk:ssm
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* feat: add issue templates for three categories

fix: add to PR template

fix: rephrase to challenge idea

fix: consistenly use h3

fix: refactor PR template

* feat(security-reporting): Added channel, and less version dependen text

* fix for colima failing with 30 seconds

* Adding Requested changes

all the requested changes are incorporated in this commit.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>
@puneeth072003
Merge branch 'master' into guide
a9ad0b5
@puneeth072003 puneeth072003 requested review from bendehaan and removed request for commjoen March 2, 2023 01:20
@puneeth072003
Copy link
Contributor Author

puneeth072003 commented Mar 2, 2023 •
edited

@bendehaan @commjoen If i run pre-commit run -a before adding a commit it modifies all the markdown files in the project,
including the Contributing.md shall i commit all the modifications it made?
In order to pass the pre-commit test....:-)

@commjoen
Copy link
Collaborator

commjoen commented Mar 2, 2023

@bendehaan @commjoen If i run pre-commit run -a before adding a commit it modifies all the markdown files in the project,

including the Contributing.md shall i commit all the modifications it made?

In order to pass the pre-commit test....:-)

Yes

@puneeth072003
Copy link
Contributor Author

@bendehaan @commjoen If i run pre-commit run -a before adding a commit it modifies all the markdown files in the project,
including the Contributing.md shall i commit all the modifications it made?
In order to pass the pre-commit test....:-)

Yes

Done:)

@puneeth072003
Copy link
Contributor Author

puneeth072003 commented Mar 2, 2023 •
edited

@bendehaan How can i fix that test that has failed?
@github-actions
Test container on podman and Colima / Test with Colima (pull_request) Failing after 4m

bendehaan
bendehaan approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@bendehaan bendehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now - thanks for your contribution!

commjoen
commjoen approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a long journey! Awesome! Welcome to the team of contributors!

@commjoen commjoen merged commit 092f0dc into OWASP:master Mar 2, 2023
@commjoen commjoen mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen commjoen approved these changes

@bendehaan bendehaan bendehaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@puneeth072003 @commjoen @bendehaan