Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(Slack): fix bug for arm on linux & Feat(#618) detect musl #664

Merged
merged 9 commits into from
Mar 3, 2023

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Mar 1, 2023

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

This PR fixes what is discussed in chat with @MarcinNowak-codes on linux-arm detection and it fixes musl detection (#618)

Relations

Closes #618
Closes #665

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen requested a review from bendehaan as a code owner March 1, 2023 22:26
@commjoen commjoen marked this pull request as draft March 1, 2023 22:27
@commjoen commjoen changed the title bugfix(xx): fix bug for arm on linux bugfix(Slack): fix bug for arm on linux && Feat(#618) detect musl Mar 2, 2023
@commjoen commjoen marked this pull request as ready for review March 2, 2023 12:19
@commjoen commjoen requested review from drnow4u and nbaars March 2, 2023 12:20
@commjoen commjoen changed the title bugfix(Slack): fix bug for arm on linux && Feat(#618) detect musl bugfix(Slack): fix bug for arm on linux & Feat(#618) detect musl Mar 2, 2023
@drnow4u
Copy link
Collaborator

drnow4u commented Mar 2, 2023

Related issue #665

@drnow4u
Copy link
Collaborator

drnow4u commented Mar 2, 2023

On macOS with x64 challenge 19 and 20 are working as expected :-)

@commjoen commjoen merged commit 9156463 into master Mar 3, 2023
@commjoen commjoen deleted the linux-arm-bug branch March 3, 2023 03:07
@drnow4u
Copy link
Collaborator

drnow4u commented Mar 3, 2023

On macOS with M1 arm64 challange 19 and 20 are working correctly.

@commjoen
Copy link
Collaborator Author

commjoen commented Mar 3, 2023

Thanks!!! Sorry, merged a little too fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Challenge 19 and 20 is not working on Apple Silicone M1 Add musl based development support
3 participants