-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change in code for windows users and adding remark in contributing.md #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Feat: initial start with k8s 1.25 migration * bump to k8s 1.25.6 in workflows * Feat(646): Adding PSA to k8s def files * feat(646): Update required config for minikube configration part 2 * feat(1.25): updated namespaced creation of vault as vault needs different security context config than our main workload * feat(1.25): updated vault liveiness checks as we have to test after every step again * feat(646): adding service account, BUT CONFIG OF APP NEEDS TO BE UPDATED TO CONTACT VAULT IN THE RIGHT NS * feat(646): First working setup for k8s minikube vault done, now preparing aws, azure, and okteto (to be finished & tested) * feat(646): complete okteto setup: we cannot do anything with workspace patching, tehrefore limitting securitycontext only * Feat(636): fix docs * feat(646): make http the same for all providers * feat(646): make precommit happy :( * fix(646): fix readmes again.... * build(deps): update hashicorp/google-beta requirement from ~> 4.54.0 to ~> 4.55.0 Updates the requirements on [hashicorp/google-beta](https://github.com/hashicorp/terraform-provider-google-beta) to permit the latest version. - [Release notes](https://github.com/hashicorp/terraform-provider-google-beta/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-google-beta/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-google-beta@v4.54.0...v4.55.0) --- updated-dependencies: - dependency-name: hashicorp/google-beta dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): update hashicorp/google requirement from ~> 4.54.0 to ~> 4.55.0 Updates the requirements on [hashicorp/google](https://github.com/hashicorp/terraform-provider-google) to permit the latest version. - [Release notes](https://github.com/hashicorp/terraform-provider-google/releases) - [Changelog](https://github.com/hashicorp/terraform-provider-google/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-provider-google@v4.54.0...v4.55.0) --- updated-dependencies: - dependency-name: hashicorp/google dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Adding the Table of contents * doc(x): added @puneeth072003 as contriubtor * Adding the requeseted changes * Making corrections * Fixed spelling * Update README.md * Feat(OWASP#646): updated centralized vault upgrade script, migrated GCP to k8s 1.25 * Feat(OWASP#646): updated gcp docs * feat(OWASP#646): Started Azure migration (Found out we have to migrate to azure identities, wIP * feat(OWASP#646): Got Kubernetes 1.25 working in Azure using audit with aad-pod-identity * fix: add terraform lockfiles * fix: fix AWS setup for k8s 1.25 * Update README.md * build(deps): bump erzz/codeclimate-standalone from 0.0.4 to 0.0.5 Bumps [erzz/codeclimate-standalone](https://github.com/erzz/codeclimate-standalone) from 0.0.4 to 0.0.5. - [Release notes](https://github.com/erzz/codeclimate-standalone/releases) - [Changelog](https://github.com/erzz/codeclimate-standalone/blob/main/CHANGELOG.md) - [Commits](erzz/codeclimate-standalone@v0.0.4...v0.0.5) --- updated-dependencies: - dependency-name: erzz/codeclimate-standalone dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update codeclimate_standalone.yml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>
updation
Adding a small note on how to handle an exception
commjoen
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Change in code for windows users and adding remark in contributing.md for Indian and other Asia-Pacific users.
Checklist: