Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eslint to pre-commit #688

Merged
merged 4 commits into from
Mar 10, 2023
Merged

feat: add eslint to pre-commit #688

merged 4 commits into from
Mar 10, 2023

Conversation

bendehaan
Copy link
Collaborator

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

This PR adds eslint in pre-commit to check our JS.

Relations

Closes #679

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests

@bendehaan bendehaan changed the title feat: add eslint feat: add eslint to pre-commit Mar 10, 2023
commjoen
commjoen approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@commjoen commjoen merged commit c843f33 into master Mar 10, 2023
@commjoen commjoen deleted the feat/add-eslint branch March 10, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen commjoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add eslint to our js setup
2 participants
@bendehaan @commjoen