Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

698 Integrate spotbugs and fix many potential java bugs #700

Merged
merged 14 commits into from
Mar 16, 2023
Merged

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Mar 13, 2023

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else: implements spotbugs as part of the OSSF passing criteria

Description

Given CodeqL is not FOSS, we have to implement something else that fulfills the scanning criteria. Spotbugs is on their list.

Relations

Closes #698

References

See https://bestpractices.coreinfrastructure.org/en/projects/7024#security:~:text=Static%20code-,analysis,-Met

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests
  • All spotbugs findings are fixed
  • Spotbugs github workflow
  • Patch some of the dependency check findings

@commjoen commjoen changed the title 698 spotbugs 698 Integrate spotbugs and fix many potential java bugs Mar 13, 2023
@commjoen commjoen marked this pull request as ready for review March 15, 2023 21:36
@bendehaan
Copy link
Collaborator

Looks like this was some work! Nice! 👏

@commjoen commjoen merged commit dd657b7 into master Mar 16, 2023
@commjoen commjoen deleted the 698-spotbugs branch March 16, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openssf: implement spotbugs
2 participants