Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save selected theme #715

Merged
merged 10 commits into from
Apr 8, 2023
Merged

fix: save selected theme #715

merged 10 commits into from
Apr 8, 2023

Conversation

turjoc120
Copy link
Contributor

@turjoc120 turjoc120 commented Mar 20, 2023

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

closes #673

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests

Copy link
Collaborator

@bendehaan bendehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the user default prefrence now always overrides the user setting for the site?

@commjoen
Copy link
Collaborator

Maybe it is better to capture this as a function with a jest test :-)?

@bendehaan
Copy link
Collaborator

Hi @turjoc120, are you currently working on this fix, or planning to continue work anytime soon?

@commjoen commjoen merged commit f80ff6a into OWASP:master Apr 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unintened Switching of Themes in WebServer
3 participants