fixes #648: Add the localstorage challenge #716

Novice-expert · 2023-03-20T18:56:16Z

What kind of changes does this PR include?

Fixes or refactors
A new challenge
Additional documentation
Something else

Description

This PR adds a new challenge i.e challenge 29.

Relations

Closes #648

References

Checklist:

All the contributions made are solely the work of me and my co-authors
I tested the changes in this PR (if applicable)
I added unit tests to ensure my change works (when change in Java or on front-end code)
The PR passes pre-commit hooks and automated tests

What kind of changes does this PR include? - [ ] Fixes or refactors - [ ✔] A new challenge - [ ] Additional documentation - [ ] Something else Description This PR adds a new challenge i.e challenge 29. Relations Closes OWASP#648 References LocalStorage Checklist: - [✔ ] All the contributions made are solely the work of me and my co-authors - [ ✔] I tested the changes in this PR (if applicable) - [✔ ] I added unit tests to ensure my change works (when change in Java or on front-end code) - [✔ ] The PR passes pre-commit hooks and automated tests

commjoen

Hi @Novice-expert ! Thank you very much for your first submission for a Challenge in OWASP WrongSecrets! That's a great first step! Please have a look at the feedback and update the PR :).

src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java

src/main/resources/explanations/challenge29.adoc

src/main/resources/explanations/challenge29_hint.adoc

src/main/resources/explanations/challenge29_reason.adoc

src/main/resources/templates/challenge.html

src/test/java/org/owasp/wrongsecrets/challenges/docker/Challenge29Test.java

separates controller, makes random local storage string

src/main/java/org/owasp/wrongsecrets/challenges/ChallengesController.java

re-added missing swagger annotations

src/main/java/org/owasp/wrongsecrets/challenges/ChallengesController.java

Fixes Challenge 29 codebase: 1: Separated controller and Challenge29 code. 2:Random string generation at every successful run of localhost.

commjoen

Almost there! Can you move the secret key to its own controller class with challenge29 as its member? And can you update the tests to tests that controller as well?

src/main/java/org/owasp/wrongsecrets/challenges/Challenge.java

src/main/java/org/owasp/wrongsecrets/challenges/ChallengesController.java

Adds dedicated rest controller for challenge 29

Update index.html endpoint for restcontroller

dedicated Rest Controller class

commjoen

Allrighty! We are almost there! Looks much better than before: minor remarks for now :)

src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java

src/test/java/org/owasp/wrongsecrets/challenges/docker/Challenge29Test.java

src/main/java/org/owasp/wrongsecrets/challenges/ChallengeRestController.java

src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java

1:- Added hidden annotation so that it doesn't through swapper API generation. 2:- Modified class Challenge29 code as per general and uniform practice. 3:- Consequently, Modified class Challenge29Test

Now the maven builds successfully. The ChallengeRestControllerTest works fine!

Adds ctf handler snippet

fixes identation

readds comments in challenge.java

fixes checkstyles

fixes identation and challenge.java

renames challenge29 to challenge30

Renames explanations

commjoen

This looks to be a good challenge! @bendehaan can you please check the texts?

commjoen · 2023-04-03T03:16:27Z

Pleave have a look at the test failures... something seems to go wrong..

fixes index.html to reduce load time

updates index.html, fixes indentation

commjoen

Thank you! Almost there! @bendehaan can you do a text review please :-)?

src/main/java/org/owasp/wrongsecrets/challenges/ChallengesController.java

src/main/resources/application.properties

…roller.java Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>

Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>

commjoen · 2023-05-05T07:27:31Z

Thank you @Novice-expert !

Novice-expert requested review from commjoen and bendehaan as code owners March 20, 2023 18:56

Novice-expert and others added 2 commits March 21, 2023 00:30

Merge branch 'master' into challenge29

06d1aaa

[pre-commit.ci lite] apply automatic fixes

6445fbf

commjoen requested changes Mar 21, 2023

View reviewed changes

Edits PR for challenge 29

1e15057

separates controller, makes random local storage string

commjoen reviewed Mar 22, 2023

View reviewed changes

src/main/java/org/owasp/wrongsecrets/challenges/ChallengesController.java Outdated Show resolved Hide resolved

Adds swagger notation

f1b2e0a

re-added missing swagger annotations

commjoen reviewed Mar 23, 2023

View reviewed changes

src/main/java/org/owasp/wrongsecrets/challenges/ChallengesController.java Outdated Show resolved Hide resolved

fixes OWASP#648

360ebba

Fixes Challenge 29 codebase: 1: Separated controller and Challenge29 code. 2:Random string generation at every successful run of localhost.

commjoen requested changes Mar 24, 2023

View reviewed changes

src/main/java/org/owasp/wrongsecrets/challenges/Challenge.java Outdated Show resolved Hide resolved

src/main/java/org/owasp/wrongsecrets/challenges/ChallengesController.java Outdated Show resolved Hide resolved

Novice-expert added 3 commits March 24, 2023 17:21

Adds dedicated rest controller

2fe05b0

Adds dedicated rest controller for challenge 29

Update index.html endpoint for restcontroller

dc17f08

Update index.html endpoint for restcontroller

rectifies PR for issue OWASP#648

814fc66

dedicated Rest Controller class

commjoen requested changes Mar 25, 2023

View reviewed changes

commjoen reviewed Mar 25, 2023

View reviewed changes

src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge29.java Outdated Show resolved Hide resolved

Novice-expert added 7 commits March 27, 2023 00:27

Added hidden annotation , modified Challenge29, Modified Challenge29Test

9575f20

1:- Added hidden annotation so that it doesn't through swapper API generation. 2:- Modified class Challenge29 code as per general and uniform practice. 3:- Consequently, Modified class Challenge29Test

Adds RestController Test.

ffdd3da

Now the maven builds successfully. The ChallengeRestControllerTest works fine!

Adds ctf handler snippet

7ee3f07

Adds ctf handler snippet

fixes identation

8831969

fixes identation

readds comments in challenge.java

7fde67f

readds comments in challenge.java

Merge branch 'OWASP:master' into challenge29

56e0662

fixes checkstyles

0c63d55

fixes checkstyles

commjoen changed the title ~~fixes #648~~ fixes #648: Add the localstorage challenge Apr 2, 2023

Novice-expert added 4 commits April 2, 2023 12:08

fixes identation and challenge.java

f3afa61

fixes identation and challenge.java

renames challenge29 to challenge30

1e519c2

renames challenge29 to challenge30

Renames explanations

8556c87

Renames explanations

Merge branch 'OWASP:master' into challenge29

d7e7e93

commjoen approved these changes Apr 3, 2023

View reviewed changes

commjoen self-requested a review April 3, 2023 03:16

Novice-expert added 2 commits April 3, 2023 10:48

fixes index.html

1b57d57

fixes index.html to reduce load time

updates index.html, fixes indentation

103e22f

updates index.html, fixes indentation

commjoen approved these changes Apr 3, 2023

View reviewed changes

Novice-expert requested a review from commjoen April 3, 2023 07:04

Novice-expert and others added 4 commits April 16, 2023 21:34

Merge branch 'master' into challenge29

3c3c8a6

Update challenge30.adoc

6af2a32

fix: update challenge 30 hint

aa88548

fix: update challenge30 reason

9254607

bendehaan requested changes May 5, 2023

View reviewed changes

src/main/java/org/owasp/wrongsecrets/challenges/ChallengesController.java Outdated Show resolved Hide resolved

src/main/resources/application.properties Outdated Show resolved Hide resolved

commjoen and others added 3 commits May 5, 2023 09:09

Merge branch 'master' into challenge29

26ccce5

Update src/main/java/org/owasp/wrongsecrets/challenges/ChallengesCont…

d1e4c4a

…roller.java Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>

Update src/main/resources/application.properties

4e181e3

Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>

bendehaan approved these changes May 5, 2023

View reviewed changes

Update challenge30 due to ongoing refactors

dd66bbc

commjoen merged commit 95596fe into OWASP:master May 5, 2023
13 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes #648: Add the localstorage challenge #716

fixes #648: Add the localstorage challenge #716

Novice-expert commented Mar 20, 2023 •

edited by commjoen

commjoen left a comment

commjoen left a comment

commjoen left a comment

commjoen left a comment

commjoen commented Apr 3, 2023

commjoen left a comment

commjoen commented May 5, 2023

fixes #648: Add the localstorage challenge #716

fixes #648: Add the localstorage challenge #716

Conversation

Novice-expert commented Mar 20, 2023 • edited by commjoen

What kind of changes does this PR include?

Description

Relations

References

Checklist:

commjoen left a comment

Choose a reason for hiding this comment

commjoen left a comment

Choose a reason for hiding this comment

commjoen left a comment

Choose a reason for hiding this comment

commjoen left a comment

Choose a reason for hiding this comment

commjoen commented Apr 3, 2023

commjoen left a comment

Choose a reason for hiding this comment

commjoen commented May 5, 2023

Novice-expert commented Mar 20, 2023 •

edited by commjoen