Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#680): added more javadoc #739

Merged
merged 17 commits into from
Apr 12, 2023
Merged

feat(#680): added more javadoc #739

merged 17 commits into from
Apr 12, 2023

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Apr 1, 2023 •
edited

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Relations

Closes #680

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen marked this pull request as ready for review April 9, 2023 06:10
@commjoen commjoen requested a review from bendehaan as a code owner April 9, 2023 06:10
bendehaan
bendehaan reviewed Apr 12, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
src/main/java/org/owasp/wrongsecrets/HerokuWebSecurityConfig.java Outdated Show resolved Hide resolved
src/main/java/org/owasp/wrongsecrets/InMemoryScoreCard.java Outdated Show resolved Hide resolved
src/main/java/org/owasp/wrongsecrets/ScoreCard.java Outdated Show resolved Hide resolved
@commjoen @bendehaan
Apply suggestions from code review
1186380 
Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>
@commjoen
Copy link
Collaborator Author

@bendehaan all changes applied :D

@commjoen commjoen merged commit 5f624d7 into master Apr 12, 2023
14 checks passed
@commjoen commjoen deleted the feat-680-javadoc branch April 12, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendehaan bendehaan bendehaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have Swagger docs and Javadocs generated
2 participants
@commjoen @bendehaan