Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature(#423): Addition of Challenge 31 (third documentation challenge) #757

Merged
merged 22 commits into from
May 17, 2023
Merged

Feature(#423): Addition of Challenge 31 (third documentation challenge) #757

merged 22 commits into from
May 17, 2023

Conversation

puneeth072003
Copy link
Contributor

@puneeth072003 puneeth072003 commented Apr 7, 2023 •
edited by commjoen

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

The challenge is to find Secret in a new tab of our project website: https://github.com/OWASP/www-project-wrongsecrets

Relations

Closes #423

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests

@puneeth072003 puneeth072003 changed the title Addition Challenge 31 Addition of Challenge 31 Apr 7, 2023
@puneeth072003
Copy link
Contributor Author

@commjoen Anything left out?

commjoen
commjoen requested changes Apr 8, 2023
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @puneeth072003 here is my first review feedback based on the implementation. Let's slack with @bendehaan on the texts of the site :D . You are almost there!

src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge31.java Outdated Show resolved Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge31.java Outdated Show resolved Hide resolved
src/test/java/org/owasp/wrongsecrets/challenges/docker/Challenge31Test.java Outdated Show resolved Hide resolved
puneeth072003 and others added 5 commits April 8, 2023 12:24
@puneeth072003 @commjoen
Update src/main/java/org/owasp/wrongsecrets/challenges/docker/Challen…
8350d76 
…ge31.java

Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
@puneeth072003 @commjoen
Update src/main/java/org/owasp/wrongsecrets/challenges/docker/Challen…
a3d231f 
…ge31.java

Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
@puneeth072003
modifications
92f75ce
@puneeth072003
resolving merge conflicts
e48c648
@puneeth072003
rearranging the code
5657e11
@puneeth072003
Copy link
Contributor Author

Just completed the other part of the challenge at OWASP/www-project-wrongsecrets#13

puneeth072003 and others added 3 commits May 6, 2023 10:00
@puneeth072003 @bendehaan
Update src/main/resources/explanations/challenge31.adoc
ad589ec 
Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>
@puneeth072003 @bendehaan
Update src/main/resources/explanations/challenge31_hint.adoc
6a4e93a 
Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>
@puneeth072003 @bendehaan
Update src/main/resources/explanations/challenge31_reason.adoc
f1f2792 
Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>
@commjoen commjoen mentioned this pull request May 6, 2023
Merged
4 tasks
@commjoen commjoen mentioned this pull request May 6, 2023
Merged
10 tasks
commjoen
commjoen requested changes May 6, 2023
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please have a look at the failing checks in the PR good sir? then we can finalize this soon, the moment OWASP/www-project-wrongsecrets#13 is completed :) .

src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge31.java Show resolved Hide resolved
@commjoen commjoen self-requested a review May 7, 2023 22:25
commjoen
commjoen approved these changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @puneeth072003 ! We can merge the moment OWASP/www-project-wrongsecrets#13 is done :)

commjoen
commjoen approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @puneeth072003 ! this would be the last one for #423 !

We can merge it when OWASP/www-project-wrongsecrets#13 is done :) .

@commjoen commjoen changed the title Addition of Challenge 31 Feature(#423): Addition of Challenge 31 May 12, 2023
@commjoen commjoen changed the title Feature(#423): Addition of Challenge 31 Feature(#423): Addition of Challenge 31 (third documentation challenge) May 14, 2023
@commjoen commjoen merged commit b687443 into OWASP:master May 17, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen commjoen approved these changes

@bendehaan bendehaan bendehaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Various github instruction secret challenges
3 participants
@puneeth072003 @commjoen @bendehaan