Code tidying, challenge difficulty refactor, removal of unnecessary code #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Hope to test & review it soon :-) |
commjoen
reviewed
Apr 27, 2023
commjoen
reviewed
Apr 27, 2023
src/main/java/org/owasp/wrongsecrets/challenges/ChallengesController.java
Show resolved
Hide resolved
commjoen
reviewed
Apr 27, 2023
src/main/java/org/owasp/wrongsecrets/challenges/Difficulty.java
Outdated
Show resolved
Hide resolved
commjoen
reviewed
Apr 27, 2023
src/main/java/org/owasp/wrongsecrets/securityconfig/ActuatorSecurityConfiguration.java
Show resolved
Hide resolved
commjoen
reviewed
Apr 27, 2023
commjoen
changed the title
|
There are some spot bugs left at https://github.com/OWASP/wrongsecrets/actions/runs/4819756896/jobs/8583373048?pr=789 :-) can you please have a look at them? Then we can merge 🚀 |
added 12 commits
April 28, 2023 14:45
The endpoints are picked up automatically and don't need extra configuration. Added test to verify all expected endpoints are present in the json response for OpenAPI.
Introduce descriptive enums to difficulty of a challenge. Furthermore, move some logic regarding displaying the difficulty level to Java.
In all cases the method throws an exception so let's inline it directly in the method.
Also format the pom file accordingly.
commjoen
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Small refactoring commits to clean up the code.
Relations
References
Checklist: