Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wire challenges to compute size dynamically. #820

Merged
merged 1 commit into from
May 17, 2023
Merged

fix: wire challenges to compute size dynamically. #820

merged 1 commit into from
May 17, 2023

Conversation

nbaars
Copy link
Collaborator

@nbaars nbaars commented May 17, 2023

Instead of increasing the number manually we can determine the size dynamically based on the number of challenges.

fix: wire challenges to compute size dynamically.
9cf822b 
Instead of increasing the number manually we can determine the size dynamically based on the number of challenges.
commjoen
commjoen approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense. Thanks!

@commjoen commjoen merged commit d62ce7f into master May 17, 2023
14 checks passed
@commjoen commjoen deleted the nbaars/dynamic-challenges branch May 17, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen commjoen approved these changes

@bendehaan bendehaan Awaiting requested review from bendehaan bendehaan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nbaars @commjoen