Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#692): Challenge 34 with a focus on determenistic use of KDFs #866

Merged
merged 5 commits into from
Jun 23, 2023
Merged

feat(#692): Challenge 34 with a focus on determenistic use of KDFs #866

merged 5 commits into from
Jun 23, 2023

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Jun 22, 2023 •
edited

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge: challenge on using KDFs on hardcoded keys
  • Additional documentation
  • Something else

Description

We now have seen various instances of people hardcoding keys, and using KDFs like PBKDF2 to "magically" generate safer not hardcoded keys, while using hardcoded values for teh function actually always generates the same (E.g. hardcoded) key.

Relations

Closes #692

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen changed the title feat(#692): initial setup of challenge 34 feat(#692): Challenge 34 with a focus on determenistic use of KDFs Jun 22, 2023
@commjoen commjoen marked this pull request as ready for review June 22, 2023 07:49
@commjoen commjoen requested a review from bendehaan as a code owner June 22, 2023 07:49
@commjoen @bendehaan
Apply suggestions from code review
57fedd7 
Co-authored-by: Ben de Haan <53901866+bendehaan@users.noreply.github.com>
@commjoen commjoen merged commit e4163cb into master Jun 23, 2023
15 checks passed
@commjoen commjoen deleted the feature-PBKDF2-challenge branch June 23, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendehaan bendehaan bendehaan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use PBKDF2 with SHA-256 on a stable static defined password ;-)
2 participants
@commjoen @bendehaan