Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More than 11 columns bugs #25

Open
Vesely opened this issue Nov 14, 2017 · 1 comment
Open

More than 11 columns bugs #25

Vesely opened this issue Nov 14, 2017 · 1 comment

Comments

@Vesely
Copy link

Vesely commented Nov 14, 2017

Hi, can you help me with this, please?
When I add more than 11 columns it to the table it looks bad.

Example code: (Based on demo)

<brainy-table items="[[users.data]]">
  <brainy-table-column name="First Name">
    <template>[[item.user.name.first]]</template>
  </brainy-table-column>
  <brainy-table-column name="Last Name">
    <template>[[item.user.name.last]]</template>
  </brainy-table-column>
  <brainy-table-column name="Email">
    <template>[[item.user.email]]</template>
  </brainy-table-column>
  <brainy-table-column name="First Name">
    <template>[[item.user.name.first]]</template>
  </brainy-table-column>
  <brainy-table-column name="Last Name">
    <template>[[item.user.name.last]]</template>
  </brainy-table-column>
  <brainy-table-column name="Email">
    <template>[[item.user.email]]</template>
  </brainy-table-column>
  <brainy-table-column name="First Name">
    <template>[[item.user.name.first]]</template>
  </brainy-table-column>
  <brainy-table-column name="Last Name">
    <template>[[item.user.name.last]]</template>
  </brainy-table-column>
  <brainy-table-column name="Email">
    <template>[[item.user.email]]</template>
  </brainy-table-column>
  <brainy-table-column name="First Name">
    <template>[[item.user.name.first]]</template>
  </brainy-table-column>
  <brainy-table-column name="Last Name">
    <template>[[item.user.name.last]]</template>
  </brainy-table-column>
</brainy-table>

Screenshot:
screenshot

Problems:

  1. Wrong last column (Sixth column has attribute is-last, but it's not last column)
  2. Data in every Email columns are cropped

Can you fix it please?
Thanks!

@Vesely Vesely changed the title More then 11 columns bugs More than 11 columns bugs Nov 17, 2017
@yglodt
Copy link

yglodt commented Aug 23, 2018

With the current version, this bug seems to exist with tables having 10 or more columns.

I "fixed" it by removing the line 115 in brainy-tr.html:

cell.toggleAttribute('is-last', cellIndex === children.length - 1);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants