Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #7

Closed
Sylry opened this issue Sep 27, 2019 · 2 comments
Closed

Add tests #7

Sylry opened this issue Sep 27, 2019 · 2 comments
Labels
enhancement New feature or request Fixed Done in dev branch but not yet released
Milestone
2.0.0

Comments

@Sylry
Copy link
Contributor

Sylry commented Sep 27, 2019

No description provided.

@Sylry Sylry added the enhancement New feature or request label Sep 27, 2019
@Sylry Sylry self-assigned this Sep 27, 2019
Sylry added a commit that referenced this issue Sep 27, 2019
@Sylry
Add basic tests. issue #7
26f0fd1
Sylry added a commit that referenced this issue Sep 27, 2019
@Sylry
Add phpstan. issue #7
85390dc
Sylry added a commit that referenced this issue Sep 27, 2019
@Sylry
Add phpstan. issue #7
7d5d72e
@Sylry
Copy link
Contributor Author

Sylry commented Sep 27, 2019

Basic tests added and phpstan tool

Some more tests are welcome :-)

@Sylry Sylry removed their assignment Sep 27, 2019
@defr defr mentioned this issue Oct 2, 2019
Merged
@defr
Copy link
Collaborator

defr commented Oct 2, 2019

I've got a bunch of tests to add, but I'd rather wait for both #8 ( to make it easier to add thoses tests without rewriting everything all the time) and #9 ( to avoid introducing incorrect assumptions in test that'll need to be updated once the parser works correctly 😉 ) before doing so.

@Sylry Sylry added this to the 2.0.0 milestone Oct 3, 2019
@Sylry Sylry added the Fixed Done in dev branch but not yet released label Oct 4, 2019
@Sylry Sylry closed this as completed Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Fixed Done in dev branch but not yet released
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@defr @Sylry