removed changes from PR390 therefore unbuyable parents can be assigned again. #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertblank
reviewed
Sep 16, 2016
There was a problem hiding this comment.
Hello Michael,
I noticed, that you did not revert the changes introduced by PR390 in the following files
- source/Application/Controller/Admin/DiscountItemAjax.php
- tests/Unit/Application/Controller/Admin/DiscountItemAjaxTest.php
Could you shortly explain, why these files should not be reverted by PR485
michaelkeiluweit
deleted the
6501-make-unbuyable-parents-assignable-again
branch
|
The bug entry describes, why the code was only partially reverted |
oxidci
pushed a commit
that referenced
this pull request
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://bugs.oxid-esales.com/view.php?id=6501#c11770 for more information, especially