Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not delete module #18

Open
wants to merge 1 commit into
base: master
from

Conversation

@keywan-ghadami-oxid
Copy link

keywan-ghadami-oxid commented Nov 15, 2019

use case: a developer installs modules from /source/modules/abbr/modulename by configuring composer to use that path as source for package installation. For example

"repositories": [
    {
      "type": "path",
      "url": "source/modules/oxps/*"
    }
  ]

This is used to develop project specific modules or to get started with the initial module development.

As composer will create symlinks to the vendor folder also debugging and adapting the php source files is straight forward.

In this case overwriting source with target by the composer plugin will destroy the module - so without this developers have to be carefully saying "no" when composer plugin asks to overwrite. with this change there are some less stupid questions when running composer update

use case: a developer installs modules from /source/modules/abbr/modulename by configuring composer to use that path as source for package installation. For example 
```
"repositories": [
    {
      "type": "path",
      "url": "source/modules/oxps/*"
    }
  ]
```
This is used to develop project specific modules or to get started with the initial module development. 

As composer will create symlinks to the vendor folder also debugging and adapting the php source files is straight forward. 

In this case overwriting source with target by the composer plugin will destroy the module - so without this developers have to be carefully saying "no" when composer plugin asks to overwrite. with this change there are some less stupid questions when running composer update
@keywan-ghadami-oxid keywan-ghadami-oxid changed the title Update ModulePackageInstaller.php do not delete module Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.