Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually revert changes made in commit 10cef8d6c64705f4b1f761773e4d34… #104

Closed
wants to merge 1 commit into from

Conversation

hansultra
Copy link

…14bac2c2da

to the file setup.sql and reimplemented the changes up to commit eb8b88f.

Reason:
Values inserted to "oxconfig.OXVARVALUE" are corrupted after commit
10cef8d.

10cef8d#diff-ca29eebff2a52d087682a2063f89f3a1

to the file setup.sql and reimplemented the changes up to commit eb8b88f.
@Sieg
Copy link
Member

Sieg commented Jul 13, 2020

Hi @hansultra, could you please tell me more about your situation? What version of the shop you are using? Have you checked the compatibility branch information in the readme? I am quite sure I have tested this before merging and pushing, but maybe I have overlooked something.

@hansultra
Copy link
Author

Dear sir,

by comparing the diff you can see that the decoded values (OXVARVALUE) committed
to "10cef8d6c64705f4b1f761773e4d3414bac2c2da" are truncated.

INSERT INTO oxconfig (OXID, OXSHOPID, OXMODULE, OXVARNAME, OXVARTYPE, OXVARVALUE, OXTIMESTAMP) VALUES

Before

  • (uuid(), 1, 'theme:wave', 'sFavicon16File', 'str', 0x79000644af5767e6228e5470901b92dbd5, NOW()),

... this inserts "favicon_16x16.png" (HEX-VALUE: 0x79000644af5767e6228e5470901b92dbd5)

After

  • ('31f2b3b1-0aeb-11ea-9849-00163e13', 1, 'theme:wave', 'sFavicon16File', 'str', 'favi', '2019-11-19 17:40:26'),

... this inserts "favi". The value for OXVARVALUE is currupted ?!

The same applies to other values inserted to oxconfig too.

I have installed OXID-Eshop with docker.
https://github.com/OXID-eSales/oxideshop_metapackage_ce/blob/b-6.2/composer.json

@Sieg
Copy link
Member

Sieg commented Jul 13, 2020

@hansultra, thanks for pointing this out! Yes, looks like those config values were corrupted during the config decoding task. In the near future, those setup.sql files will be removed in master, as those were meant to be used in older shop versions where we had no configuration coming from theme.php file. Please ignore this for now, and use the default theme activation procedure which uses theme.php values for installation.

Let me know if we are missing something more and you really need those setup.sql files to stay, but with reasons ;)

Have a nice day!

@Sieg
Copy link
Member

Sieg commented Jul 28, 2020

Hey @hansultra, wanted to inform you that we have removed the setup.sql in master already as I have been mentioning earlier (4fbd6cb). Thanks again for pointing this out.

@Sieg Sieg closed this Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants