Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update morepics.tpl #123

Conversation

oxidsimongassenschmidt
Copy link
Contributor

In case of sAltImageUrl set, the current implementation doesn't work.

In case of sAltImageUrl set, the current implementation doesn't work.
@keywan-ghadami-oxid
Copy link
Contributor

Using a url together with getimagesize can cause massive slowdown of the system, this was changed in past to avoid this performance issue.

Maybe there is way to fix this by introducing a new method:
getMasterZoomPictureSize() which can try to get the size from local filesystem, and fallback to static values in case remote pictures are used.

@oxidsimongassenschmidt
Copy link
Contributor Author

If the picture is not present on the current file system, you get no function at all atm.

and in php8 you get a fatal error according to https://bugs.oxid-esales.com/view.php?id=7236

so a working solution - maybe rewriting the js or the whole template - is also fine for me ;)

@Sieg
Copy link
Member

Sieg commented Oct 29, 2021

@oxidsimongassenschmidt, how about reusing the sZoomImageSize theme setting? then we dont really need the size of those images..?

@Sieg
Copy link
Member

Sieg commented Oct 29, 2021

Like this:

[{assign var="aPictureInfo" value="*"|explode:$oViewConf->getViewThemeParam("sZoomImageSize")}]
[{foreach...

@Sieg Sieg closed this Mar 7, 2023
@Sieg Sieg reopened this Mar 7, 2023
@Sieg
Copy link
Member

Sieg commented Mar 9, 2023

I have pushed my suggestion, as there were no complains about it: 154dbf1

@Sieg Sieg closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants