You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Don't check for active settings not defined in metadata.php
After enabling the ddoewysiwyg module the "Issue found!" flag persists. This is because this module registers two config values (1, 2) in the onActivate event which aren't defined in the metadata.php. Either this is bad practice and ddoewysiwyg should get fixed or the following part should be removed or mitigated to not raise the "Issue found!" flag:
Hi Adrian, I totally agree with the first point, maybe it can be fixed in they patch release.
About the second point, I am not that sure maybe it can be fixed in the affected module by registering that variables in the metadata. For me it looks like that module does a kind of dirty hack, I would like to investigate a bit depper into that before doing workarounds for that.
IMHO there are two parts with potential to optimize issue detection:
After enabling the ddoewysiwyg module the "Issue found!" flag persists. This is because this module registers two config values (1, 2) in the
onActivate
event which aren't defined in the metadata.php. Either this is bad practice andddoewysiwyg
should get fixed or the following part should be removed or mitigated to not raise the "Issue found!" flag:oxid-module-internals/Core/InternalModule.php
Lines 429 to 431 in 3ef5180
The text was updated successfully, but these errors were encountered: