Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize issue detection in module list #32

Closed
adriankirchner opened this issue Nov 28, 2018 · 2 comments
Closed

Optimize issue detection in module list #32

adriankirchner opened this issue Nov 28, 2018 · 2 comments
Assignees
Projects
Milestone

Comments

@adriankirchner
Copy link
Collaborator

adriankirchner commented Nov 28, 2018

IMHO there are two parts with potential to optimize issue detection:

  1. [EDIT by Keywan] moved to do not scan deactivated modules #35
  2. Don't check for active settings not defined in metadata.php
    After enabling the ddoewysiwyg module the "Issue found!" flag persists. This is because this module registers two config values (1, 2) in the onActivate event which aren't defined in the metadata.php. Either this is bad practice and ddoewysiwyg should get fixed or the following part should be removed or mitigated to not raise the "Issue found!" flag:
    if (!isset($aResult[ $sName ])) {
    $aResult[ $sName ] = -1;
    $this->stateFine = false;
@keywan-ghadami-oxid
Copy link
Contributor

Hi Adrian, I totally agree with the first point, maybe it can be fixed in they patch release.

About the second point, I am not that sure maybe it can be fixed in the affected module by registering that variables in the metadata. For me it looks like that module does a kind of dirty hack, I would like to investigate a bit depper into that before doing workarounds for that.

@keywan-ghadami-oxid keywan-ghadami-oxid added this to the 2.0.0 milestone Jan 1, 2019
@keywan-ghadami-oxid keywan-ghadami-oxid self-assigned this Jan 1, 2019
@keywan-ghadami-oxid keywan-ghadami-oxid added this to To do in 2.0 via automation Jan 1, 2019
@keywan-ghadami-oxid keywan-ghadami-oxid moved this from To do to In progress in 2.0 Jan 1, 2019
@keywan-ghadami-oxid keywan-ghadami-oxid moved this from In progress to Done in 2.0 Jan 1, 2019
@keywan-ghadami-oxid
Copy link
Contributor

fixed, by ignoring additional settings not listed in metadata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.0
  
Done
Development

No branches or pull requests

2 participants