Pippa creation #4
Conversation
This reverts commit 2316ec9.
* added new character, pig-morph Pippa, and an (unobtainable pig transformative item)
| import classes.Util.InCollection; | ||
| import classes.Util.RandomInCollection;; | ||
|
|
||
| public class Swineapple extends ItemSlotClass |
There was a problem hiding this comment.
Any suggestions on who should sell this, assuming it's fine to add to the game?
There was a problem hiding this comment.
Most likely, it will turn up as an unlockable or standard item in Jade's inventory. Don't worry about tying it into the code just yet though as it may be handled afterwards--if and when this content is reviewed, approved and merged.
| PIPPA_TALKED_HER - Check if Steele has talked to Pippa about herself | ||
| undefined/0 - Have not talked to Pippa about herself | ||
| 1 - Have talked to Pippa about herself | ||
| PIPPA_TALKED_YAMMI - Check if Steele has talked to Pippa about Yammi |
There was a problem hiding this comment.
Might be getting ahead of myself, but I think it's obvious from a few spots that I would like to make Pippa a crew member in a future expansion. In her joining the crew, I'd like to have crossover scenes with Yammi and Reaha, as well as the ability to purchase access to new oil types for her to use in her massages. Thoughts on that?
There was a problem hiding this comment.
Adding flags for possible future expansions should be fine. As long as they are planned ahead of time so when you do get to expansion content, there wouldn't be a need to retroactively fix encounters and whatnot.
As far as interacting with other characters, that is also fine. But if you want to be on the safe/courteous side, I would advise contacting the original author(s) to review your work and make sure your additions are consistent with their characters, if you can.
There was a problem hiding this comment.
I've got no beef with it. Just so long as any interactions are kosher, it'll be swine by me.
Seriously though just popping in to let you know that I'm aware of this submission. It's just piled up after a bunch of other stuff. The backlog never ends!
There was a problem hiding this comment.
Thank you both.
|
Just a heads up that Im doing some reviewing tonight! |
|
Okay, there's a few places I'd to tweak or refine, but this is really quality. You did good work man. (Sorry the wait was so long!) |
|
Thanks for the review, and the compliment. Totally open to tweaks/refinement. No problem on the wait; it's a pretty big chunk of content (dropped unexpectedly) and I'm sure you're pretty busy. |
|
Basically, I'm too doofy to figure out how to take this PR and throw it at the private TiTS repo. Looks like Gedan got it for me while I slept last night, so I'm going to close it here. Expect to see her in game soon(tm). |
I added a character to Uveto named Pippa; she's a pig morph. I hope she's acceptable (I'm, of course, open to feedback). I also added an item that's a pig transformative, but it's unobtainable, because I wasn't sure which shop, if any of the existing ones, would be appropriate. Thanks for your work.